feat: add exposure service #60
Open
+614
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new exposure service to track exposure events while deprecating the existing assignment service. The exposure service provides similar functionality to assignments but with a modernized API and improved structure.
- Added new
ExposureServiceinterface andAmplitudeExposureServiceimplementation for tracking exposure events - Deprecated
AssignmentServiceand related classes in favor of the new exposure tracking system - Added
tracksExposureoption toEvaluateOptionsto enable exposure event tracking
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/node/src/exposure/exposure.ts | Defines core Exposure class and interfaces for the exposure tracking system |
| packages/node/src/exposure/exposure-service.ts | Implements AmplitudeExposureService with event conversion logic |
| packages/node/src/exposure/exposure-filter.ts | Implements in-memory caching filter to prevent duplicate exposure tracking |
| packages/node/src/types/config.ts | Adds ExposureConfig type and deprecates AssignmentConfig |
| packages/node/src/local/client.ts | Integrates exposure service and adds tracksExposure option to evaluate methods |
| packages/node/src/assignment/assignment.ts | Adds deprecation notices to assignment tracking interfaces |
| packages/node/src/assignment/assignment-service.ts | Adds deprecation notices to assignment service implementation |
| packages/node/src/assignment/assignment-filter.ts | Adds deprecation notice to assignment filter |
| packages/node/test/local/exposure/exposure-service.test.ts | Tests for exposure service event conversion and tracking |
| packages/node/test/local/exposure/exposure-filter.test.ts | Tests for exposure filter deduplication logic |
| packages/node/test/local/client.test.ts | Integration test for tracksExposure option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📝 Documentation updates detected! New suggestion: Document exposure tracking for Node.js Experiment SDK local evaluation |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding exposure service, deprecating assignment service, and adding tracksExposure to evaluate options.
Checklist