feat: add assignment and exposure event tracking options #41
Conversation
|
📝 Documentation updates detected! New suggestion: Document FetchOptions for PHP Experiment SDK |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the RemoteEvaluationClient to support additional fetch options for tracking assignments and exposures. The changes introduce a new FetchOptions class that encapsulates flag keys and tracking preferences, making the API more flexible and extensible.
- Adds
tracksAssignmentandtracksExposurefields toFetchOptionsfor controlling tracking behavior - Refactors the
fetchmethod to accept either an array of flag keys, aFetchOptionsobject, or null - Implements HTTP header handling (
X-Amp-Exp-TrackandX-Amp-Exp-Exposure-Track) based on tracking options
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Remote/FetchOptions.php | Added tracksAssignment and tracksExposure properties with nullable bool types and default values |
| src/Remote/RemoteEvaluationClient.php | Refactored fetch method to accept multiple argument types and extracted core logic to fetchWithOptions private method |
| tests/Remote/RemoteEvaluationClientTest.php | Added comprehensive test coverage for various FetchOptions scenarios including tracking headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ($arg !== null && is_array($arg)) { | ||
| return $this->fetchWithOptions($user, new FetchOptions($arg, null, null)); | ||
| } | ||
| if ($arg !== null && is_object($arg) && $arg instanceof FetchOptions) { |
There was a problem hiding this comment.
The check is_object($arg) is redundant when followed by $arg instanceof FetchOptions. The instanceof operator already returns false for non-objects. Simplify line 131 to just if ($arg !== null && $arg instanceof FetchOptions).
| if ($arg !== null && is_object($arg) && $arg instanceof FetchOptions) { | |
| if ($arg !== null && $arg instanceof FetchOptions) { |
Adds track, or not to track, assignment and exposure events options to fetch requests.