ci: release: upload_to_cloudsmith.sh: switch upload script to cloudsmith #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt the upload_to_cloudsmith.sh to use the proper variables and use the python script from wiki-scripts repository for upload. Remove upload_to_artifactory.py due to cloudsmith switch. Signed-off-by: Andreea Andrisan <[email protected]>
AAndrisa
requested review from
CiprianRegus,
SRaus,
amiclaus,
buha,
dbogdan and
rbolboac
as code owners
amiclaus
reviewed
Dec 18, 2025
Contributor
amiclaus
left a comment
amiclaus
left a comment
There was a problem hiding this comment.
small inline comments, otherwise lgtm.
| BINARY_ALIAS="noos_projects_binaries" | ||
| SRC_ALIAS="_no-os_sources" | ||
| PYSCRIPT_PATH="ci/release/upload_to_artifactory.py" | ||
| PYSCRIPT_PATH="wiki-scripts/utils/cloudsmith_utils/upload_to_cloudsmith.py" |
Contributor
There was a problem hiding this comment.
maybe validate if the script actually exists at this path.
| --local_path noos_exports_${platform} --token ${ART_TOKEN} --props_level 1 \ | ||
| --properties "git_sha=${short_hash}" --log_file upload_to_artifactory_log.txt --no_rel_path | ||
| python3 ${WORKING_DIRECTORY}/${PYSCRIPT_PATH} \ | ||
| --repo=${CLOUDSMITH_REPO} \ |
Contributor
There was a problem hiding this comment.
use consistent formatting. --repo="${CLOUDSMITH_REPO}". also the indentation is odd here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adapt the upload_to_cloudsmith.sh to use the proper variables and use the python script from wiki-scripts repository for upload.
Remove upload_to_artifactory.py due to cloudsmith switch.
PR Type
PR Checklist