Added new regions #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have found that India has appeared as a region in a couple of NES games, so it report an error on the log: "WARNING [TwinBee (India) (En) (Pirate)]: no recognizable regions found" Those are the only two roms with "India" a as region (in all the No-Intro datasets of all systems : https://datomatic.no-intro.org/index.php?page=show_record&s=45&n=2146 https://datomatic.no-intro.org/index.php?page=show_record&s=45&n=8157 Both are in english. There are no Hindi ("hi" as ISO language) language roms that are known of, at least belonging to the "India" region.
|
I will be doing a lot of 1G1R of other systems on the following days, so there is not hurry in commiting this. I may add other new regions. |
|
Just to add, that I have indeed tested all of them with the script, and it works fine, the log no longer reports anything. So it is safe to commit. |
Added "Scandinavia" and "Peru"
The standard is "IN", rather than "IND" for India. The same with "PE" rather than "PER" with Peru.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that India has appeared as a region in a couple of NES games, so it report an error on the log:
"WARNING [TwinBee (India) (En) (Pirate)]: no recognizable regions found"
Those are the only two roms with "India" a as region (in all the No-Intro datasets of all systems :
https://datomatic.no-intro.org/index.php?page=show_record&s=45&n=2146
https://datomatic.no-intro.org/index.php?page=show_record&s=45&n=8157
Both are in english. There are no Hindi ("hi" as ISO language) language roms that are known of, at least belonging to the "India" region. So I have not added it as a lenguage, only English (en).