Skip to content

Conversation

@hossain-khan
Copy link
Contributor

Right now, all the links resolves to 404 due to extra ../ removing project name from the path.

  • Before: https://github.com/android/commit/ee8e27289f4bc36304ee9f04397f49c35f402a65
  • After: https://github.com/android/compose-samples/commit/ee8e27289f4bc36304ee9f04397f49c35f402a65
  • Before: https://github.com/android/tree/v2024.05.00/Jetsurvey
  • After: https://github.com/android/compose-samples/tree/v2024.05.00/Jetsurvey

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hossain-khan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where several resource links in the README.md file were broken, leading to 404 errors. By adjusting the relative paths, the changes ensure that all listed project and commit links are now functional, significantly improving the accuracy and navigability of the project's documentation.

Highlights

  • Link Correction: Updated relative paths for project and commit links within the README.md file to resolve 404 errors.
  • Documentation Accuracy: Ensured that all resource links in the project's main documentation now correctly point to their intended destinations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes broken links in the README.md file by adjusting the relative path depth. While the fix is correct, I've suggested an improvement to use absolute URLs for these links. This will make them more robust and work correctly regardless of the context in which the README is rendered, and it also aligns with the style of other links in the document.

Comment on lines +101 to +104
| [Crane](../../tree/v2024.05.00/Crane) | 2024-08-02 | [ee8e272](../../commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Owl](../../tree/v2024.05.00/Owl) | 2024-08-02 | [ee8e272](../../commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Jetsurvey](../../tree/v2024.05.00/Jetsurvey) | 2024-08-02 | [ee8e272](../../commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Rally](../../tree/v2024.05.00/Rally) | 2024-08-02 | [ee8e272](../../commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the relative links you've added are correct, it's a good practice to use absolute links for resources within a repository's documentation. This ensures that the links remain valid even if the content is viewed outside of the GitHub web UI (e.g., in a local editor or a different rendering tool).

Using absolute URLs would also make these links consistent with others in this file, like those under the 'High level features' section.

Suggested change
| [Crane](../../tree/v2024.05.00/Crane) | 2024-08-02 | [ee8e272](../../commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Owl](../../tree/v2024.05.00/Owl) | 2024-08-02 | [ee8e272](../../commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Jetsurvey](../../tree/v2024.05.00/Jetsurvey) | 2024-08-02 | [ee8e272](../../commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Rally](../../tree/v2024.05.00/Rally) | 2024-08-02 | [ee8e272](../../commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Crane](https://github.com/android/compose-samples/tree/v2024.05.00/Crane) | 2024-08-02 | [ee8e272](https://github.com/android/compose-samples/commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Owl](https://github.com/android/compose-samples/tree/v2024.05.00/Owl) | 2024-08-02 | [ee8e272](https://github.com/android/compose-samples/commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Jetsurvey](https://github.com/android/compose-samples/tree/v2024.05.00/Jetsurvey) | 2024-08-02 | [ee8e272](https://github.com/android/compose-samples/commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |
| [Rally](https://github.com/android/compose-samples/tree/v2024.05.00/Rally) | 2024-08-02 | [ee8e272](https://github.com/android/compose-samples/commit/ee8e27289f4bc36304ee9f04397f49c35f402a65) |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must have been reasons to use relative path! 🤔

@riggaroo riggaroo merged commit 20a31c9 into android:main Nov 26, 2025
2 checks passed
@hossain-khan hossain-khan deleted the patch-1 branch November 26, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants