-
Notifications
You must be signed in to change notification settings - Fork 124
Add support for more types of DWARF data #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calebh
wants to merge
20
commits into
angr:master
Choose a base branch
from
draperlaboratory:function_parameters
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+545
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e more typical ref4)
…. Added count, lower_bound and upper_bound to ArrayType.
… can handle any attribute. An error is now thrown if the reference form is not one we can understand.
…e. Changed and simplified implementation of resolve_reference_addr to make use of this method. Cleaned up imports that are now unused.
… and discr_values to variant_cases. Added some more accessors.
…ant to having byte_size missing. TypeDefType now knows what namespace it is in. Added more resilience to DWARF information about inline functions.
…t, rvalue reference, shared and volatile types. Accomplished this by making a new TypeModifier superclass. ConstType now inherits from this new superclass.
…tory/cle into function_parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances CLE's capabilities to load DWARF information, particularly for Rust binaries. There will be a corresponding pull request in angr to take advantage of these changes to CLE. The current purpose of this pull request is to gather feedback on architecture/design. Note that the CLE side here is a bit more well tested than the angr side.
Summary of changes:
EnumerationType,SubroutineType,SubprogramType,ConstType,VariantTypeas subclasses of VariableType. Adds functions to load these classes from DWARF information.Subprogram, which inherited fromLexicalBlock. Figure out ifSubprogramTypeshould remain separate from this class.See also: angr/angr#5857