-
Notifications
You must be signed in to change notification settings - Fork 414
feat(medialive): add Elemental MediaLive modules to community collection #2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 37s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 51s (non-voting) |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 35s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 40s (non-voting) |
|
I'm seeing two issues with this PR:
I've also asked for guidance in the #ansible-aws channel in Libera to help move this forward. |
|
@buxell If you rebase your PR, then the Documentation build failures should be fixed. The forum post you created is the best place to get help with the IAM permissions |
b4233e0 to
b360ae5
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 56s (non-voting) |
Adds new modules for AWS Elemental MediaLive management: - medialive_sdi_source: Manage SDI source configurations - medialive_node: Handle node operations - medialive_network: Configure network settings - medialive_input: Manage input configurations - medialive_cluster: Control cluster operations - medialive_channel_placement_group: Manage channel placement groups This enhancement enables comprehensive management of MediaLive resources through Ansible automation, supporting bring-your-own-device Elemental Anywhere systems. Co-authored-by: Sergey Papyan <[email protected]> Co-authored-by: David Teach <[email protected]> Co-authored-by: Brenton Buxell <[email protected]>
b360ae5 to
4628e9a
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 35s (non-voting) |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 15s (non-voting) |
|
I have created a companion PR in the aws.terminator repository that adds the required MediaLive IAM permissions needed for these integration tests to pass. Once that PR is merged, the CI failures here should be resolved. This PR should now be ready for review. |
alinabuzachis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buxell Thank you for your impressive contribution. Would it make sense to you to split this PR into several ones to make the review process easier?
| @@ -0,0 +1,3 @@ | |||
| minor_changes: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For new modules you not need changelog fragments, so, please remove these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
plugins/modules/medialive_channel.py
Outdated
| options: | ||
| cdi_input_specification: | ||
| description: | ||
| - Specification of CDI inputs for this channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Specification of CDI inputs for this channel | |
| - Specification of CDI inputs for this channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
plugins/modules/medialive_channel.py
Outdated
| suboptions: | ||
| resolution: | ||
| description: | ||
| - Maximum CDI input resolution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Maximum CDI input resolution | |
| - Maximum CDI input resolution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
plugins/modules/medialive_channel.py
Outdated
| suboptions: | ||
| password_param: | ||
| description: | ||
| - key used to extract the password from EC2 Parameter store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - key used to extract the password from EC2 Parameter store | |
| - Key used to extract the password from EC2 Parameter store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
plugins/modules/medialive_channel.py
Outdated
| type: str | ||
| stream_name: | ||
| description: | ||
| - Stream name for RTMP destinations (URLs of type rtmp://) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Stream name for RTMP destinations (URLs of type rtmp://) | |
| - Stream name for RTMP destinations (URLs of type rtmp://). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
plugins/modules/medialive_channel.py
Outdated
| suboptions: | ||
| password_param: | ||
| description: | ||
| - key used to extract the password from EC2 Parameter store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - key used to extract the password from EC2 Parameter store | |
| - Key used to extract the password from EC2 Parameter store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
plugins/modules/medialive_channel.py
Outdated
| - 'DVBDASH_7_CLEAN_FEED' | ||
| feature_activations: | ||
| description: | ||
| - Feature Activations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Feature Activations | |
| - Feature Activations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
plugins/modules/medialive_channel.py
Outdated
| suboptions: | ||
| black_frame_msec: | ||
| description: | ||
| - Documentation update needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Documentation update needed | |
| - Documentation update needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
| class MediaLiveWaiterFactory(BaseWaiterFactory): | ||
| '''Custom waiter factory for MediaLive channel placement group resources''' | ||
|
|
||
| @property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move this custom waiter to https://github.com/ansible-collections/amazon.aws/blob/main/plugins/module_utils/waiters.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got rid of custom waiters in favor of official ones
| ) | ||
|
|
||
|
|
||
| def do_update_channel(self, params): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to move some of the shared logic to a plugins/modules_utils/medialive.py file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there isn't enough shared logic to make it worth it
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 41s (non-voting) |
Hi @alinabuzachis. I am one of the contributors and I've taken over the shepherding of this PR from @buxell.
|
|
On a different note - could you possibly take a look at this PR as well, @alinabuzachis? I believe I've seen you review older PRs on |
|
Closing this in favor of #2353 |
SUMMARY
Adds new modules for AWS Elemental MediaLive to enable infrastructure-as-code management of MediaLive resources. These modules support automation of MediaLive configurations including Elemental Anywhere (bring-your-own-device) setups.
The following modules are included in this PR:
ISSUE TYPE
COMPONENT NAME
aws.medialive
ADDITIONAL INFORMATION
These modules expand the AWS collection's coverage to include MediaLive services, particularly useful for organizations managing broadcast and streaming workflows through Ansible automation.
Testing completed:
Contributors: