Skip to content

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue #6960

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 21, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Preview failed

@gemini-code-assist
Copy link

Summary of Changes

Hello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a unified mechanism for managing and customizing CSS class prefixes throughout the component library. By integrating a getPrefixCls function into the ConfigProvider, components can now consistently derive their class names, supporting both global and individual component-level prefix overrides. This enhancement significantly improves the flexibility of styling and ensures a cohesive approach to class naming conventions across the library, with the AutoCenter component serving as an initial adopter of this new pattern.

Highlights

  • Centralized Class Prefix Management: Introduced a getPrefixCls utility function within the ConfigProvider to standardize how CSS class prefixes are generated across components, ensuring consistency and flexibility.
  • Customizable Prefixes: Components can now receive an optional prefixCls prop, allowing for individual component-level customization that overrides the global prefixCls set in ConfigProvider.
  • AutoCenter Component Integration: The AutoCenter component has been refactored to utilize the new getPrefixCls utility, demonstrating the new pattern for dynamic class prefixing.
  • Documentation and Testing Updates: Updated both English and Chinese documentation for ConfigProvider to include the new prefixCls prop, and adjusted test cases to reflect the addition of getPrefixCls to the useConfig hook's return value.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the feature label Oct 21, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2025

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6963

commit: 015185b

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (bfde19d) to head (015185b).

Additional details and impacted files
@@           Coverage Diff            @@
##           feature    #6963   +/-   ##
========================================
  Coverage    92.95%   92.95%           
========================================
  Files          337      337           
  Lines         7368     7370    +2     
  Branches      1871     1861   -10     
========================================
+ Hits          6849     6851    +2     
  Misses         483      483           
  Partials        36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

此 PR 统一了为组件提供自定义 prefixCls 的方式,通过在 ConfigProvider 中引入 getPrefixCls 函数来实现。这是一个很好的改进,可以提高组件库的灵活性和可定制性。

代码实现方面,AutoCenter 组件已正确适配了新的 prefixCls 机制。

我发现 ConfigProvider 的实现中存在一个性能问题:传递给上下文(Context)的 value 对象没有被记忆化(memoized),这可能导致不必要的组件重渲染。我已在相关代码处提出了具体的反馈和优化建议。

除此之外,其他部分的修改(包括文档和测试)看起来都很不错。

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant