Skip to content

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue #6960

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Preview failed

@gemini-code-assist
Copy link

Summary of Changes

Hello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在为组件提供统一的 CSS 类名前缀管理机制。通过在 ConfigProvider 中引入 prefixCls 属性和 getPrefixCls 方法,开发者可以更灵活地控制组件的样式命名空间,避免潜在的样式冲突,并提高组件库的可定制性。Button 组件已率先适配此新机制,并增加了相应的测试和文档。

Highlights

  • 统一前缀配置: 引入 ConfigProvider 来统一管理组件的 CSS 类名前缀,允许全局设置或组件级别覆盖,增强了组件库的可定制性。
  • Button 组件适配: Button 组件现在支持通过 prefixCls 属性自定义其类名前缀,并能从 ConfigProvider 获取默认值,实现了与新配置机制的集成。
  • 测试用例增强: 增加了新的测试用例和快照,以验证自定义类名前缀功能的正确性,包括 ConfigProvider 和组件自身 prefixCls 的优先级处理。
  • 文档更新: 更新了英文和中文文档,明确说明了 ConfigProvider 新增的 prefixCls 属性及其用途,方便开发者理解和使用。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the feature label Oct 21, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2025

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6966

commit: d1de569

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (bfde19d) to head (d1de569).

Additional details and impacted files
@@           Coverage Diff            @@
##           feature    #6966   +/-   ##
========================================
  Coverage    92.95%   92.95%           
========================================
  Files          337      337           
  Lines         7368     7370    +2     
  Branches      1871     1871           
========================================
+ Hits          6849     6851    +2     
  Misses         483      483           
  Partials        36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully unifies the way custom class prefixes are provided by introducing a getPrefixCls function in the ConfigProvider. The changes are well-implemented across the Button component, its tests, and the ConfigProvider itself. The documentation has also been updated accordingly.

I have one suggestion regarding performance optimization in the ConfigProvider component.

Comment on lines 84 to 91
const getPrefixCls = (suffixCls?: string, customizePrefixCls?: string) => {
if (customizePrefixCls) {
return customizePrefixCls
}
const mergedPrefixCls =
config.prefixCls || parentConfig.prefixCls || defaultPrefixCls
return suffixCls ? `${mergedPrefixCls}-${suffixCls}` : mergedPrefixCls
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For performance optimization, it's a good practice to memoize functions that are passed down through React context. The getPrefixCls function is recreated on every render of ConfigProvider, which can cause unnecessary re-renders in consuming components.

Consider wrapping getPrefixCls with useCallback to prevent this. You'll also need to import useCallback from react.

Here's an example:

  const getPrefixCls = useCallback((suffixCls?: string, customizePrefixCls?: string) => {
    if (customizePrefixCls) {
      return customizePrefixCls
    }
    const mergedPrefixCls =
      config.prefixCls || parentConfig.prefixCls || defaultPrefixCls
    return suffixCls ? `${mergedPrefixCls}-${suffixCls}` : mergedPrefixCls
  }, [config.prefixCls, parentConfig.prefixCls])

@EmilyyyLiu EmilyyyLiu force-pushed the feature-prefixCls-button branch from 6401a9e to d1de569 Compare October 23, 2025 06:52
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant