-
Couldn't load subscription status.
- Fork 2.5k
feat(Popup CenterPopup): unified provision of custom prefixCls #6974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在增强 Popup 和 CenterPopup 组件的样式定制能力,通过引入统一的自定义类名前缀机制,解决了相关 issue #6960。现在,开发者可以更灵活地控制这两个组件的 CSS 类名前缀,无论是通过全局配置还是组件局部属性,从而更好地集成到不同的设计系统中,提升了组件的可配置性和复用性。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #6974 +/- ##
========================================
Coverage 92.95% 92.95%
========================================
Files 337 337
Lines 7368 7370 +2
Branches 1871 1835 -36
========================================
+ Hits 6849 6851 +2
- Misses 483 511 +28
+ Partials 36 8 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 旨在统一 Popup 和 CenterPopup 组件的自定义 prefixCls。整体实现很棒,通过 useConfig 中的 getPrefixCls 来动态生成类名前缀,并更新了相关测试用例,确保了功能的正确性。
我发现有两处硬编码的 CSS 类名 adm-plain-anchor,这与本次 PR 的目标(统一自定义前缀)有些相悖。我已经提出了具体的修改建议,以便完全支持前缀的自定义。除此之外,代码质量很高。
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5480f8f to
440f91d
Compare

统一添加自定义class 前缀
关联issue #6960