Skip to content

Conversation

@EmilyyyLiu
Copy link
Contributor

统一添加自定义class 前缀
关联issue #6960

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Preview is ready

@gemini-code-assist
Copy link

Summary of Changes

Hello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在增强 Popup 和 CenterPopup 组件的样式定制能力,通过引入统一的自定义类名前缀机制,解决了相关 issue #6960。现在,开发者可以更灵活地控制这两个组件的 CSS 类名前缀,无论是通过全局配置还是组件局部属性,从而更好地集成到不同的设计系统中,提升了组件的可配置性和复用性。

Highlights

  • 统一前缀类名管理: Popup 和 CenterPopup 组件现在支持通过 ConfigProvider 或组件自身的 prefixCls 属性来统一管理自定义类名前缀。
  • 优先级处理: 组件自身的 prefixCls 属性将覆盖 ConfigProvider 中设置的全局前缀,提供了更细粒度的控制。
  • 动态获取前缀: 移除了硬编码的 classPrefix,改为通过 useConfig 钩子中的 getPrefixCls 方法动态生成类名前缀,增强了灵活性和可维护性。
  • 类型定义更新: PopupBaseProps 类型定义中新增了 prefixCls?: string 属性,以支持自定义前缀的传入。
  • 测试覆盖: 增加了相应的测试用例,确保自定义前缀的正确应用和优先级逻辑符合预期。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the feature label Oct 23, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 23, 2025

npm i https://pkg.pr.new/ant-design/ant-design-mobile/antd-mobile@6974

commit: 440f91d

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (bfde19d) to head (440f91d).

Additional details and impacted files
@@           Coverage Diff            @@
##           feature    #6974   +/-   ##
========================================
  Coverage    92.95%   92.95%           
========================================
  Files          337      337           
  Lines         7368     7370    +2     
  Branches      1871     1835   -36     
========================================
+ Hits          6849     6851    +2     
- Misses         483      511   +28     
+ Partials        36        8   -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 旨在统一 PopupCenterPopup 组件的自定义 prefixCls。整体实现很棒,通过 useConfig 中的 getPrefixCls 来动态生成类名前缀,并更新了相关测试用例,确保了功能的正确性。

我发现有两处硬编码的 CSS 类名 adm-plain-anchor,这与本次 PR 的目标(统一自定义前缀)有些相悖。我已经提出了具体的修改建议,以便完全支持前缀的自定义。除此之外,代码质量很高。

@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant