feat(List CheckList): unified provision of custom prefixCls #6975
Conversation
dosubot
bot
added
the
size:L
|
|
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在增强 Ant Design Mobile 中 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a unified approach to providing custom class prefixes for the CheckList and List components, enhancing styling flexibility and consistency. The changes involve modifying the CheckList, CheckListItem, and List components to utilize the useConfig hook for retrieving the class prefix, allowing for customization through the ConfigProvider. Additionally, the corresponding tests have been updated to ensure the correct application of the custom prefixes.
| import classNames from 'classnames' | ||
| import { CheckListValue } from '.' | ||
|
|
||
| const classPrefix = `adm-check-list-item` |
There was a problem hiding this comment.
This constant is no longer used after the changes and should be removed to avoid confusion and improve code clarity. It's important to remove dead code to maintain a clean and understandable codebase.
| import { mergeProp } from '../../utils/with-default-props' | ||
| import { useConfig } from '../config-provider' | ||
|
|
||
| const classPrefix = `adm-list-item` |
There was a problem hiding this comment.
This constant is no longer used after the changes and should be removed to avoid confusion and improve code clarity. It's important to remove dead code to maintain a clean and understandable codebase.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature #6975 +/- ##
========================================
Coverage 92.95% 92.95%
========================================
Files 337 337
Lines 7368 7372 +4
Branches 1871 1871
========================================
+ Hits 6849 6853 +4
- Misses 483 511 +28
+ Partials 36 8 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
统一添加自定义class 前缀
关联issue #6960