feat(Checkbox): unified provision of custom prefixCls #6976
Conversation
dosubot
bot
added
the
size:M
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a prefixCls prop to the Checkbox component, allowing for custom class prefixes to be applied. This change enhances the component's flexibility and theming capabilities by enabling developers to easily integrate it into different design systems or customize its appearance. The changes include modifying the CheckboxProps interface, updating the component's class names to use the new prefix, and adding tests to verify the functionality of the custom prefix.
| import { isDev } from '../../utils/is-dev' | ||
| import { NativeInput } from './native-input' | ||
|
|
||
| const classPrefix = `adm-checkbox` |
There was a problem hiding this comment.
This constant is no longer used after the change. It should be removed to avoid confusion and reduce unnecessary code.
| [`${classPrefix}-indeterminate`]: props.indeterminate, | ||
| [`${classPrefix}-disabled`]: disabled, | ||
| [`${classPrefix}-block`]: props.block, | ||
| className={classNames(prefixCls, { |
There was a problem hiding this comment.
Consider adding a comment explaining the purpose of this className and how it's constructed. This will improve readability and maintainability.
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #6976 +/- ##
========================================
Coverage 92.95% 92.95%
========================================
Files 337 337
Lines 7368 7370 +2
Branches 1871 1872 +1
========================================
+ Hits 6849 6851 +2
Misses 483 483
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
统一添加自定义class 前缀
关联issue #6960