feat(Sender): tag slot add clear btn #1317

IsDyh01 · 2025-11-10T10:14:42Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://x.ant.design/changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

github-actions · 2025-11-10T10:14:51Z

gemini-code-assist · 2025-11-10T10:15:01Z

Summary of Changes

Hello @IsDyh01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a user experience enhancement to the SlotTextArea component by adding a clear button to 'tag' type slots. This allows users to easily remove individual tags, improving the interactivity and manageability of slotted content within the input field. The change involves both UI modifications and the underlying logic to handle slot removal and state updates.

Highlights

New Feature: Tag Slot Clear Button: A clear button (represented by a 'CloseOutlined' icon) has been added to 'tag' type slots within the SlotTextArea component, allowing users to remove individual tags directly from the input area.
Slot Removal Logic: A new function, removeTagSlot, was implemented to handle the complete removal process of a tag slot. This includes removing the DOM element, updating the internal slot configuration and values, and triggering the onChange callback to reflect the updated content.
Snapshot Test Update: The snapshot test for demo-extend.test.ts.snap has been updated to reflect the new UI structure of tag slots, which now includes the clear button.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new feature to allow clearing/removing 'tag' type slots in the Sender component. A new function removeTagSlot is added to handle the removal logic, and a close button is added to the tag slot's UI. The implementation is mostly correct and covers all necessary state updates. However, I've found a significant type-safety issue related to event handling that could lead to runtime errors for consumers of this component. My review comments provide suggestions to fix this.

packages/x/components/sender/SlotTextArea.tsx

gemini-code-assist · 2025-11-10T10:16:47Z

packages/x/components/sender/SlotTextArea.tsx

+                  onClick={(e) => {
+                    removeTagSlot(node.key as string, e as unknown as EventType);
+                  }}


Following the change in removeTagSlot, the onClick handler should be updated to not pass the event object. The event from onClick is a MouseEvent, which is incompatible with the EventType expected by onChange.

Suggested change

onClick={(e) => {

removeTagSlot(node.key as string, e as unknown as EventType);

}}

onClick={() => {

removeTagSlot(node.key as string);

}}

codecov · 2025-11-10T10:18:58Z

Bundle Report

Changes will increase total bundle size by 10.04kB (0.25%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
x-markdown-array-push	3.96MB	10.04kB (0.25%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: x-markdown-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`mermaid.min.js`	10.04kB	3.96MB	0.25%

coderabbitai · 2025-11-10T10:23:41Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-11-10T10:25:54Z

Codecov Report

❌ Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.18%. Comparing base (8815a87) to head (a616827).

Files with missing lines	Patch %	Lines
packages/x/components/sender/SlotTextArea.tsx	96.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1317      +/-   ##
==========================================
+ Coverage   94.16%   94.18%   +0.02%     
==========================================
  Files         141      141              
  Lines        3670     3700      +30     
  Branches     1008     1039      +31     
==========================================
+ Hits         3456     3485      +29     
- Misses        212      213       +1     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kimteayon · 2025-11-10T12:39:09Z

您好关闭功能需要配置以及文档

IsDyh01 · 2025-11-11T02:32:52Z

tag类型新增一个isClearable属性吗

kimteayon · 2025-11-11T05:27:15Z

tag类型新增一个isClearable属性吗

和antd 一致 allowClear

kimteayon · 2025-11-20T06:51:39Z

这个先稍等下、sender的词槽模式准备重构下逻辑

IsDyh01 · 2025-11-20T11:25:54Z

好的

feat(Sender): tag slot add clear btn

35675fd

dosubot bot added the enhancement New feature or request label Nov 10, 2025

gemini-code-assist bot reviewed Nov 10, 2025

View reviewed changes

IsDyh01 and others added 6 commits November 11, 2025 14:51

docs(Sender): update tag slot docs

3d20d90

fix(docs): fix docs

ad19484

test: add test case

b8be7f8

fix: delete log

59dfe1a

test: add test case

6e3d0a4

Merge branch 'next' into feat/tag-add-clear-btn

a616827

Uh oh!

feat(Sender): tag slot add clear btn #1317

Are you sure you want to change the base?

feat(Sender): tag slot add clear btn #1317

Uh oh!

Conversation

IsDyh01 commented Nov 10, 2025

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Nov 10, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

coderabbitai bot commented Nov 10, 2025

Review skipped

Other AI code review bot(s) detected

Uh oh!

codecov bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kimteayon commented Nov 10, 2025

Uh oh!

IsDyh01 commented Nov 11, 2025

Uh oh!

kimteayon commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kimteayon commented Nov 20, 2025

Uh oh!

IsDyh01 commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 10, 2025 •

edited

Loading

codecov bot commented Nov 10, 2025 •

edited

Loading

codecov bot commented Nov 10, 2025 •

edited

Loading

kimteayon commented Nov 11, 2025 •

edited

Loading