fix: use conditional import for NotRequired to match dependency spec
#358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing_extensions is only installed on Python < 3.11 (per pyproject.toml), so we need to try importing NotRequired from stdlib typing first, then fall back to typing_extensions for older Python versions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
harupy
changed the title
NotRequired to match dependency spec
harupy
commented
Nov 23, 2025
| from pathlib import Path | ||
| from typing import TYPE_CHECKING, Any, Literal, TypedDict | ||
|
|
||
| from typing_extensions import NotRequired |
Contributor
Author
There was a problem hiding this comment.
Since the mcp package (and many packages also) requries typing_extensions, this import actually doesn't fail even in Python >= 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
typing_extensionsis only installed on Python < 3.11 (perpyproject.toml)typing_extensionsfails on Python 3.11+ where the package isn't installedtypingfirst, falling back totyping_extensionsfor older Python versionsTest plan
🤖 Generated with Claude Code