C++ fixes #224
Open
C++ fixes #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc 10 in C++20 mode requires that the allocator type match the type used to allocate, so do that by adding "const" to the key type.
These const specifiers were ignored by older versions of gcc, likely because they are in template members that are not instantiated. gcc 14 refuses to compile the class. Fix by removing the const specifiers. This is safe since these members are private, so we aren't allowing external users permissions to modify them.
|
Considering that actually using the copy constructor or copy assignment operator for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series contains a couple of C++ fixes, one for C++20, the other for
stricter template compile checks in g++14.