Skip to content

Conversation

@stephengaito
Copy link

Terence,

Now that your contribution system is significantly easier and clearer (many thanks) I am issuing a pull request on some patches I made about 5-6 months ago.

I have just merged them into the antlr/antlr3/master branch with out any conflicts.

These patches fix a number of release-phase errors in the files uploaded when you switched over to using GitHub. I have made one patch per branch in my fork (should you want more details).

The patches are (taken from each commit message):

  1. fix for C target antlr3commontree::setParent -- currently it sets the parent's parent but we want the parent itself.
  2. C.stg template in antlr v3.4 as released has all references to FOLLOW_set_in commented out - BUT the corresponding template on gitHub shows no changes to this section of code from before the v3.4 release -- making the gitHub C.stg reflect the v3.4 released version.
  3. fix for noRewrite template invocation missing arguments in ASTTreeParser.stg file
  4. C.stg template in antlr v3.4 as released uses NULL for null entries in the dfa _transitions table - BUT the corresponding template on gitHub shows no changes to this section of code from before the v3.4 release -- making the gitHub C.stg reflect the v3.4 released version
  5. fix for Anonymous template missing single argument in the creation of stream_XXX->free code in the ASTTreeParser.stg file

I signed the contributors.txt file on 2012/09/21

Regards,

Stephen Gaito

…_set_in commented out - BUT the corresponding template on gitHub shows no changes to this section of code from before the v3.4 release -- making the gitHub C.stg reflect the v3.4 released version
…n the dfa _transitions table - BUT the corresponding template on gitHub shows no changes to this section of code from before the v3.4 release -- making the gitHub C.stg reflect the v3.4 released version
… stream_XXX->free code in the ASTTreeParser.stg file
… parent's parent but we want the parent itself
Rad87 added a commit to Rad87/antlr3 that referenced this pull request Oct 31, 2013
@parrt
Copy link
Member

parrt commented Nov 8, 2013

Hi. trying to clean up. Can you look at this changs again with respect to new antlr/antlr3 master? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants