Fix type assertion panic in GetFlowTableID #7515
Merged
+120
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GetFlowTableID function was incorrectly attempting to cast tableCache objects directly to binding.Table, but the cache stores *Table wrapper objects. The wrapper's ofTable field contains the actual binding.Table implementation. This caused a panic in the `/ovsflows` HTTP handler. Fix the type assertion to match the pattern used in getTableByID: ``` objs[0].(*Table).ofTable.GetID() ``` Also add unit tests for GetFlowTableID, GetFlowTableName, and GetTableList to prevent regressions. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added
kind/bug
hongliangl
approved these changes
Oct 27, 2025
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Oct 27, 2025
The GetFlowTableID function was incorrectly attempting to cast tableCache objects directly to binding.Table, but the cache stores *Table wrapper objects. The wrapper's ofTable field contains the actual binding.Table implementation. This caused a panic in the `/ovsflows` HTTP handler. Fix the type assertion to match the pattern used in getTableByID: ``` objs[0].(*Table).ofTable.GetID() ``` Also add unit tests for GetFlowTableID, GetFlowTableName, and GetTableList to prevent regressions. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
added a commit
to antoninbas/antrea
that referenced
this pull request
Oct 27, 2025
The GetFlowTableID function was incorrectly attempting to cast tableCache objects directly to binding.Table, but the cache stores *Table wrapper objects. The wrapper's ofTable field contains the actual binding.Table implementation. This caused a panic in the `/ovsflows` HTTP handler. Fix the type assertion to match the pattern used in getTableByID: ``` objs[0].(*Table).ofTable.GetID() ``` Also add unit tests for GetFlowTableID, GetFlowTableName, and GetTableList to prevent regressions. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetFlowTableID function was incorrectly attempting to cast tableCache objects directly to binding.Table, but the cache stores *Table wrapper objects. The wrapper's ofTable field contains the actual binding.Table implementation. This caused a panic in the
/ovsflowsHTTP handler.Fix the type assertion to match the pattern used in getTableByID:
Also add unit tests for GetFlowTableID, GetFlowTableName, and GetTableList to prevent regressions.