Fix issue 1884 - Ambiguous column reference error in SET clause #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error occured due to SET transform not checking if the target entry for the RHS item is already present in the query target list and added the item to tl which resulted in variable name conflict. Instead transformed the item and added to tl only if target entry for the var name could not be found Added regression tests
github-actions
bot
added
master
override-stale
jrgemignani
reviewed
May 17, 2024
| */ | ||
| if (IsA(set_item->expr, ColumnRef)) | ||
| { | ||
| query->hasAggs = true; |
Contributor
There was a problem hiding this comment.
Was this intentionally removed?
| } | ||
| } | ||
|
|
||
| if (!query->hasAggs && nodeTag(target_item->expr) == T_Aggref) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error occured due to SET transform not checking if the target entry for the RHS item is already present in the query target list and added the item to tl which resulted in variable name conflict.
Instead transformed the item and added to tl only if target entry for the var name could not be found
Added regression tests