-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add description about Gen-AI contributions to our guide #60158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ If I could force people to read this before opening a PR, I would. I've seen a lot of that recently.
|
Fwiw some prior art on pip's side: pypa/pip#13470. I think many other projects also have policies that vary is strictness. |
Indeed. We also had an ASF-internal discussion and many projects approach it in similar way as well.
I think also it makes sense to do it in a "local" way -> i.e. put it in the context of the project , and I think repeating it multiple times when people will not follow it will have a "deterring" effect, people simply try different things not even realising the effect it has on maintainets, but having it written down and being able - by any of us - to simply link to this policy and close PRs without much discussion will automatically decrease a number of those - also because the future AI agents will learn to not open such requests based on those responses (or so I hope). |
|
Apache Spark has a PR template item about the usage of AI added in apache/spark#42469 |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also ass a note into https://github.com/apache/airflow/blob/main/.github/PULL_REQUEST_TEMPLATE.md ?
Let's discuss in devlist thread but, It would likely be a good idea. |
57aaeb0 to
fee1192
Compare
d307896 to
b2b9695
Compare
Co-authored-by: Pierre Jeambrun <[email protected]>
b2b9695 to
24db6ce
Compare
24db6ce to
1606c71
Compare
jedcunningham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess my days of simply deleting the full template are over 😅.
Generated-by: Jed
We can make exception for you 😄 |
Co-authored-by: Jed Cunningham <[email protected]>
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…60158) * Add description about Gen-AI contributions to our guide * Update contributing-docs/05_pull_requests.rst Co-authored-by: Pierre Jeambrun <[email protected]> * fixup! Update contributing-docs/05_pull_requests.rst * Update contributing-docs/05_pull_requests.rst Co-authored-by: Jed Cunningham <[email protected]> --------- (cherry picked from commit 7d7908d) Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Pierre Jeambrun <[email protected]> Co-authored-by: Jed Cunningham <[email protected]>
* Add description about Gen-AI contributions to our guide * Update contributing-docs/05_pull_requests.rst Co-authored-by: Pierre Jeambrun <[email protected]> * fixup! Update contributing-docs/05_pull_requests.rst * Update contributing-docs/05_pull_requests.rst Co-authored-by: Jed Cunningham <[email protected]> --------- Co-authored-by: Pierre Jeambrun <[email protected]> Co-authored-by: Jed Cunningham <[email protected]>
…60158) (#60332) * Add description about Gen-AI contributions to our guide * Update contributing-docs/05_pull_requests.rst * fixup! Update contributing-docs/05_pull_requests.rst * Update contributing-docs/05_pull_requests.rst --------- (cherry picked from commit 7d7908d) Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Pierre Jeambrun <[email protected]> Co-authored-by: Jed Cunningham <[email protected]>

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.