Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 6, 2026


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jan 6, 2026
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ If I could force people to read this before opening a PR, I would. I've seen a lot of that recently.

@notatallshaw
Copy link
Contributor

Fwiw some prior art on pip's side: pypa/pip#13470. I think many other projects also have policies that vary is strictness.

@potiuk
Copy link
Member Author

potiuk commented Jan 6, 2026

Fwiw some prior art on pip's side: pypa/pip#13470. I think many other projects also have policies that vary is strictness.

Indeed. We also had an ASF-internal discussion and many projects approach it in similar way as well.

❤️ If I could force people to read this before opening a PR, I would. I've seen a lot of that recently.

I think also it makes sense to do it in a "local" way -> i.e. put it in the context of the project , and I think repeating it multiple times when people will not follow it will have a "deterring" effect, people simply try different things not even realising the effect it has on maintainets, but having it written down and being able - by any of us - to simply link to this policy and close PRs without much discussion will automatically decrease a number of those - also because the future AI agents will learn to not open such requests based on those responses (or so I hope).

@tirkarthi
Copy link
Contributor

Apache Spark has a PR template item about the usage of AI added in apache/spark#42469

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potiuk
Copy link
Member Author

potiuk commented Jan 6, 2026

Apache Spark has a PR template item about the usage of AI added in apache/spark#42469

Shall we also ass a note into https://github.com/apache/airflow/blob/main/.github/PULL_REQUEST_TEMPLATE.md ?

Let's discuss in devlist thread but, It would likely be a good idea.

@potiuk potiuk force-pushed the propose-gen-ai-chapter branch 7 times, most recently from 57aaeb0 to fee1192 Compare January 7, 2026 10:44
@potiuk
Copy link
Member Author

potiuk commented Jan 7, 2026

I tried to come up with a good template and used the opportunity to update it a bit.

Unfortunately we cannot use the .yml format as we do for issues and we cannot make any fields "mandatory" here.

I experimented a bit and I came up with this:

image

And this is how it looks like after crating PR without providing any description (other than the one coming from commit message)

potiuk#321

I think it's prominent enough and if someone does not check it but uses AI we can easily call-out on it.

@potiuk potiuk force-pushed the propose-gen-ai-chapter branch 2 times, most recently from d307896 to b2b9695 Compare January 7, 2026 10:55
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my days of simply deleting the full template are over 😅.

Generated-by: Jed

@potiuk
Copy link
Member Author

potiuk commented Jan 9, 2026

I guess my days of simply deleting the full template are over 😅.

Generated-by: Jed

We can make exception for you 😄

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit 7d7908d into apache:main Jan 9, 2026
70 checks passed
@potiuk potiuk deleted the propose-gen-ai-chapter branch January 9, 2026 14:33
github-actions bot pushed a commit that referenced this pull request Jan 9, 2026
…60158)

* Add description about Gen-AI contributions to our guide

* Update contributing-docs/05_pull_requests.rst

Co-authored-by: Pierre Jeambrun <[email protected]>

* fixup! Update contributing-docs/05_pull_requests.rst

* Update contributing-docs/05_pull_requests.rst

Co-authored-by: Jed Cunningham <[email protected]>

---------
(cherry picked from commit 7d7908d)

Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Pierre Jeambrun <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
* Add description about Gen-AI contributions to our guide

* Update contributing-docs/05_pull_requests.rst

Co-authored-by: Pierre Jeambrun <[email protected]>

* fixup! Update contributing-docs/05_pull_requests.rst

* Update contributing-docs/05_pull_requests.rst

Co-authored-by: Jed Cunningham <[email protected]>

---------

Co-authored-by: Pierre Jeambrun <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
potiuk added a commit that referenced this pull request Jan 9, 2026
…60158) (#60332)

* Add description about Gen-AI contributions to our guide

* Update contributing-docs/05_pull_requests.rst



* fixup! Update contributing-docs/05_pull_requests.rst

* Update contributing-docs/05_pull_requests.rst



---------
(cherry picked from commit 7d7908d)

Co-authored-by: Jarek Potiuk <[email protected]>
Co-authored-by: Pierre Jeambrun <[email protected]>
Co-authored-by: Jed Cunningham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.