Restore ability to mark task groups as success/failed in UI #60161

arjav1528 · 2026-01-06T11:56:04Z

Description

This PR adds two new React components that restore the task group marking functionality:

MarkGroupTaskInstanceAsButton - A dropdown button component that allows users to select a state (success/failed) and opens a dialog for confirmation
MarkGroupTaskInstanceAsDialog - A dialog component that provides:
- Options to include past/future/upstream/downstream task instances
- Dry-run preview showing which task instances will be affected
- Ability to add notes to the state change
- Bulk update using the task instance bulk API for efficiency

The button is integrated into the Group Task Instance page header, alongside the existing Clear button.

Screenshots

Solves #60121

bohdan-pd · 2026-01-06T12:31:14Z

@arjav1528 Thank you for working on that! 👍

arjav1528 · 2026-01-06T18:56:29Z

@arjav1528 Thank you for working on that! 👍

is the UI ok or do you want me to refactor that

bbovenzi

Thanks for taking this on! Do you mind doing more manually testing to find where MarkAs isn't quite working? I think there are some issues with the API that we need to tackle before we can merge any UI changes.

...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx

providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py

bbovenzi

I tried using this locally and still had issues. Could you both manually test this out and also add fastapi test for dry runs?

arjav1528 · 2026-01-07T19:50:01Z

I tried using this locally and still had issues. Could you both manually test this out and also add fastapi test for dry runs?

Sorry about the trouble. I’ve tested this locally and couldn’t reproduce the issue. I have reproduced the issue, solved it, you can run it locally now

arjav1528 · 2026-01-08T14:17:04Z

I tried using this locally and still had issues. Could you both manually test this out and also add fastapi test for dry runs?

Sorry about the trouble. I’ve tested this locally and couldn’t reproduce the issue. I have reproduced the issue, solved it, you can run it locally now

@bbovenzi I am not sure why is this test failing, coz I havent made any changes related to this

bbovenzi

Looking much better! Just a few more comments

...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx

…alog components for task instance state management

…task instance handling

…ces in MarkGroupTaskInstanceAsDialog

…rs to preview changes without affecting state

…oks to ensure correct functionality

…dering and improve dialog behavior

…ateTaskInstancesDryRun for better debugging and monitoring

…updates, covering various scenarios including authentication, request validation, and state changes

…alog

…ect running task state

pierrejeambrun

Thank you for that pull request. People have been asking for this feature back a lot! 🎉

For the two reasons mentioned bellow (crafting the payload requires all the TIs of the group which isn't easy to get on the client side because of pagination + the return type of the API will create confusion).

I think the best approach is to create a couple of endpoint specifically for patching a TI group. (dry_run and non dry_run version). Refactoring and reusing the code of the patch ti endpoint, because it already returns a TaskInstanceCollectionResponse (for the scenario of patching all mapped index at once).

This should make this PR much simpler. (basically just a simple call to patch, with the group id + payload, and apply the change to all tasks within the group)

pierrejeambrun · 2026-01-09T15:44:05Z

...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx

+  const { data: groupTaskInstances } = useTaskInstanceServiceGetTaskInstances(
+    {
+      dagId,
+      dagRunId: runId,
+      taskGroupId: groupId,
+    },
+    undefined,
+    {
+      enabled: open,
+    },
+  );


For instance by doing this, you only retrieve the first page, the 50 first TI of the group, not all the TIs, so you could be missing some.

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

…or task group updates and dry run functionality

…ality in the API

…ooks and update request body validation

arjav1528 · 2026-01-09T19:22:57Z

@bbovenzi are there any changes left?, would love to implement them
could you please merge this PR at your availability

jason810496

Nice! Thanks for the PR!

jason810496 · 2026-01-11T04:05:36Z

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

+    if not group_tis:
+        raise HTTPException(
+            status.HTTP_404_NOT_FOUND,
+            f"No task instances found for task group '{task_group_id}' in DAG '{dag_id}' and run '{dag_run_id}'",
+        )


Would it be better to move the if not group_tis: raise ... case handling to _get_task_group_task_instances as well?

jason810496 · 2026-01-11T04:09:07Z

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

+    # Collect all affected task instances (including upstream/downstream/future/past)
+    all_affected_tis: list[TI] = []
+    seen_ti_keys: set[tuple[str, str, str, int]] = set()


It seems we could consolidate all_affected_tis: list and seen_ti_keys: set as a dict.

jason810496 · 2026-01-11T04:14:38Z

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

+            # Update state and get all affected TIs (including upstream/downstream/future/past)
+            updated_tis = dag.set_task_instance_state(
+                task_id=ti.task_id,
+                run_id=dag_run_id,
+                map_indexes=map_indexes,
+                state=data["new_state"],
+                upstream=body.include_upstream or False,
+                downstream=body.include_downstream or False,
+                future=body.include_future or False,
+                past=body.include_past or False,
+                commit=True,
+                session=session,
+            )
+
+            if not updated_tis:
+                raise HTTPException(
+                    status.HTTP_409_CONFLICT,
+                    f"Task id {ti.task_id} is already in {data['new_state']} state",
+                )
+
+            # Track unique affected TIs and trigger listeners
+            for updated_ti in updated_tis:
+                ti_key = (
+                    updated_ti.dag_id,
+                    updated_ti.run_id,
+                    updated_ti.task_id,
+                    updated_ti.map_index if updated_ti.map_index is not None else -1,
+                )
+                if ti_key not in seen_ti_keys:
+                    seen_ti_keys.add(ti_key)
+                    all_affected_tis.append(updated_ti)
+
+                    # Trigger listeners
+                    try:
+                        if data["new_state"] == TaskInstanceState.SUCCESS:
+                            get_listener_manager().hook.on_task_instance_success(
+                                previous_state=None, task_instance=updated_ti
+                            )
+                        elif data["new_state"] == TaskInstanceState.FAILED:
+                            get_listener_manager().hook.on_task_instance_failed(
+                                previous_state=None,
+                                task_instance=updated_ti,
+                                error=f"TaskInstance's state was manually set to `{TaskInstanceState.FAILED}`.",
+                            )
+                    except Exception:


We could use _patch_task_instance_state helper here I think.

airflow/airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py

Lines 96 to 97 in a51ba2f

def _patch_task_instance_state(

task_id: str,

jason810496 · 2026-01-11T05:43:41Z

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

+    # Process each task in the group
+    for ti in group_tis:
+        # Update state if requested
+        if data.get("new_state"):


Should the check be

if data.get("new_state"): # For each task in the group, simulate state change for ti in group_tis:

here? So that we can skip whole the loop if we don't update the state.

jason810496 · 2026-01-11T05:46:36Z

airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py

+        # Refresh the affected TIs from the database to get the latest state and notes
+        ti_keys_list = list(seen_ti_keys)
+        refreshed_tis = session.scalars(
+            select(TI)
+            .where(tuple_(TI.dag_id, TI.run_id, TI.task_id, TI.map_index).in_(ti_keys_list))
+            .options(joinedload(TI.rendered_task_instance_fields))
+        ).all()
+        all_affected_tis = list(refreshed_tis)
+
+        # Also include group TIs that had notes updated but weren't in the state change list
+        # (to avoid duplicates, only add TIs not already in seen_ti_keys)
+        if data.get("note") is not None:
+            for ti in group_tis:
+                ti_key = (
+                    ti.dag_id,
+                    ti.run_id,
+                    ti.task_id,
+                    ti.map_index if ti.map_index is not None else -1,
+                )
+                if ti_key not in seen_ti_keys:
+                    seen_ti_keys.add(ti_key)
+                    all_affected_tis.append(ti)


Same as above, we are able to consolidate as one dict instead of having list and set.

@jason810496 I have applied all the changes, do review them, and merge as per your availability after the CI checks

…o the service layer

…ate update logic and removing listener triggers

…ion for improved clarity and reuse in task instance patching

arjav1528 requested review from bbovenzi, guan404ming, pierrejeambrun, ryanahamilton, shubhamraj-git and vatsrahul1001 as code owners January 6, 2026 11:56

boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 6, 2026

arjav1528 force-pushed the main branch 2 times, most recently from 5db3cd8 to c9d177e Compare January 6, 2026 18:50

arjav1528 marked this pull request as draft January 6, 2026 18:50

arjav1528 marked this pull request as ready for review January 6, 2026 18:50

arjav1528 force-pushed the main branch from c9d177e to c112fef Compare January 6, 2026 19:38

bbovenzi reviewed Jan 6, 2026

View reviewed changes

...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx Outdated Show resolved Hide resolved

...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx Outdated Show resolved Hide resolved

arjav1528 force-pushed the main branch from c112fef to 6797ea1 Compare January 7, 2026 03:40

arjav1528 requested review from bugraoz93, ephraimbuddy, jason810496, potiuk and rawwar as code owners January 7, 2026 05:08

bbovenzi reviewed Jan 7, 2026

View reviewed changes

providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py Outdated Show resolved Hide resolved

arjav1528 force-pushed the main branch 2 times, most recently from b068b63 to da03292 Compare January 7, 2026 16:39

bbovenzi reviewed Jan 7, 2026

View reviewed changes

arjav1528 force-pushed the main branch 3 times, most recently from d24fdae to 34153d8 Compare January 8, 2026 13:12

arjav1528 requested a review from choo121600 as a code owner January 8, 2026 13:12

arjav1528 force-pushed the main branch from 34153d8 to 68f1202 Compare January 8, 2026 18:36

bbovenzi reviewed Jan 8, 2026

View reviewed changes

...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx Outdated Show resolved Hide resolved

...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx Outdated Show resolved Hide resolved

arjav1528 force-pushed the main branch from 9212f60 to 62f1212 Compare January 8, 2026 22:34

arjav1528 added 11 commits January 9, 2026 10:47

feat: add MarkGroupTaskInstanceAsButton and MarkGroupTaskInstanceAsDi…

98dbfee

…alog components for task instance state management

fix: add map_index parameter to BulkTaskInstanceService for improved …

4560637

…task instance handling

feat: implement bulk update and dry run functionality for task instan…

92ec9fd

…ces in MarkGroupTaskInstanceAsDialog

feat: add dry run option for bulk task instance updates, allowing use…

80c10fd

…rs to preview changes without affecting state

test: add unit tests for MarkGroupTaskInstanceAsDialog and related ho…

74001e0

…oks to ensure correct functionality

test: update MarkGroupTaskInstanceAsDialog tests to include async ren…

818595c

…dering and improve dialog behavior

feat: enhance logging in MarkGroupTaskInstanceAsDialog and useBulkUpd…

0866033

…ateTaskInstancesDryRun for better debugging and monitoring

test: add unit tests for dry run functionality in bulk task instance …

ed924fe

…updates, covering various scenarios including authentication, request validation, and state changes

refactor: remove unused note parameter from MarkGroupTaskInstanceAsDi…

338e2b8

…alog

fix: update button disabled state in MarkGroupTaskInstanceAsDialog

ee5d340

test: update mock data in MarkGroupTaskInstanceAsDialog tests to refl…

adaa454

…ect running task state

arjav1528 force-pushed the main branch from 62f1212 to adaa454 Compare January 9, 2026 05:17

pierrejeambrun reviewed Jan 9, 2026

View reviewed changes

arjav1528 added 3 commits January 9, 2026 21:50

feat: implement usePatchTaskGroup and usePatchTaskGroupDryRun hooks f…

6e2276d

…or task group updates and dry run functionality

feat: add patch endpoints for task group updates and dry run function…

287db1b

…ality in the API

test: refactor MarkGroupTaskInstanceAsDialog tests to use new patch h…

1d82ad9

…ooks and update request body validation

arjav1528 requested review from bbovenzi and pierrejeambrun January 9, 2026 18:21

jason810496 reviewed Jan 11, 2026

View reviewed changes

arjav1528 added 3 commits January 11, 2026 11:33

refactor: move HTTP 404 exception handling for task group instances t…

24b9720

…o the service layer

refactor: streamline task instance state patching by consolidating st…

46af5a9

…ate update logic and removing listener triggers

refactor: extract request body validation logic into a separate funct…

d74ea9b

…ion for improved clarity and reuse in task instance patching

Restore ability to mark task groups as success/failed in UI #60161

Are you sure you want to change the base?

Restore ability to mark task groups as success/failed in UI #60161

Uh oh!

Conversation

arjav1528 commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots

Solves #60121

Uh oh!

bohdan-pd commented Jan 6, 2026

Uh oh!

arjav1528 commented Jan 6, 2026

Uh oh!

bbovenzi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbovenzi left a comment

Choose a reason for hiding this comment

Uh oh!

arjav1528 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arjav1528 commented Jan 8, 2026

Uh oh!

bbovenzi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pierrejeambrun Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arjav1528 commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

jason810496 Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

jason810496 Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

jason810496 Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

jason810496 Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

jason810496 Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

arjav1528 Jan 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arjav1528 commented Jan 6, 2026 •

edited

Loading

arjav1528 commented Jan 7, 2026 •

edited

Loading

pierrejeambrun left a comment •

edited

Loading

arjav1528 commented Jan 9, 2026 •

edited

Loading