Skip to content

Rewrite ParquetRecordBatchStream in terms of the PushDecoder #8159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 10, 2025
+428 −666
Merged

Rewrite ParquetRecordBatchStream in terms of the PushDecoder #8159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73a16cf
Rework async reader to use decoder
alamb Aug 15, 2025
db876a9
Apply suggestions from code review
alamb Nov 4, 2025
3d6a204
Merge remote-tracking branch 'apache/main' into alamb/test_decode_wit…
alamb Nov 4, 2025
3ec7448
Explain use of std::mem::replace
alamb Nov 4, 2025
ee64444
Fix comment
alamb Nov 4, 2025
dd683bd
Remove file_length from the ParquetPushDecoderBuilder
alamb Nov 4, 2025
53cd99d
Fix comments
alamb Nov 4, 2025
4ab1206
Merge branch 'main' into alamb/test_decode_with_async_reader
alamb Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions parquet/src/arrow/arrow_reader/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,13 @@ pub mod statistics;
/// [`StatisticsConverter`]: statistics::StatisticsConverter
/// [Querying Parquet with Millisecond Latency]: https://arrow.apache.org/blog/2022/12/26/querying-parquet-with-millisecond-latency/
pub struct ArrowReaderBuilder<T> {
/// The "input" to read parquet data from.
///
/// Note in the case of the [`ParquetPushDecoderBuilder`], there
/// is no underlying input, which is indicated by a type parameter of [`NoInput`]
///
/// [`ParquetPushDecoderBuilder`]: crate::arrow::push_decoder::ParquetPushDecoderBuilder
/// [`NoInput`]: crate::arrow::push_decoder::NoInput
pub(crate) input: T,

pub(crate) metadata: Arc<ParquetMetaData>,
Expand Down
Loading
Loading