GH-47709 : [C++][FlightRPC] Return ODBC and data source information #47762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
lidavidm
reviewed
Oct 9, 2025
| // Driver Information | ||
|
|
||
| TYPED_TEST(FlightSQLODBCTestBase, TestSQLGetInfoActiveEnvironments) { | ||
| this->Connect(); |
There was a problem hiding this comment.
Could the connect/disconnect be put in a SetUp/TearDown?
Also it might not be wise to add the tests directly to FlightSQLODBCTestBase; could we create a fixture for this test suite specifically (by subclassing)?
There was a problem hiding this comment.
yes, added separate test fixture ConnectionInfoTest
github-actions
bot
added
awaiting changes
kou
reviewed
Oct 9, 2025
| TYPED_TEST(FlightSQLODBCTestBase, TestSQLGetInfoDriverName) { | ||
| this->Connect(); | ||
|
|
||
| Validate(this->conn, SQL_DRIVER_NAME, (SQLWCHAR*)L"Arrow Flight ODBC Driver"); |
alinaliBQ
force-pushed
the
gh-47709-sql-get-info
branch
from
e6f61c6 to
49745a6
Compare
alinaliBQ
commented
Oct 20, 2025
| // Driver Information | ||
|
|
||
| TYPED_TEST(FlightSQLODBCTestBase, TestSQLGetInfoActiveEnvironments) { | ||
| this->Connect(); |
There was a problem hiding this comment.
yes, added separate test fixture ConnectionInfoTest
| TYPED_TEST(FlightSQLODBCTestBase, TestSQLGetInfoDriverName) { | ||
| this->Connect(); | ||
|
|
||
| Validate(this->conn, SQL_DRIVER_NAME, (SQLWCHAR*)L"Arrow Flight ODBC Driver"); |
github-actions
bot
added
awaiting change review
lidavidm
reviewed
Oct 21, 2025
github-actions
bot
added
awaiting changes
lidavidm
reviewed
Oct 22, 2025
Comment on lines
29
to
33
| template <typename T> | ||
| class ConnectionInfoTest : public T { | ||
| public: | ||
| using List = std::list<T>; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| template <typename T> | |
| class ConnectionInfoTest : public T { | |
| public: | |
| using List = std::list<T>; | |
| }; | |
| template <typename T> | |
| class ConnectionInfoTest : public T { | |
| }; |
There was a problem hiding this comment.
done, rebased and removed using List
github-actions
bot
added
awaiting changes
Co-Authored-By: rscales <[email protected]> Create connection_info_test.cc Add SQLGetInfo tests Co-authored-by: justing-bq <[email protected]> Co-Authored-By: rscales <[email protected]> Address code review comments Co-authored-by: justing-bq <[email protected]> Work on code review comments Fix build issues with tests
* fix build issues
alinaliBQ
force-pushed
the
gh-47709-sql-get-info
branch
from
5452bfd to
f7a7386
Compare
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ODBC needs to give BI tools information about the driver itself and the data source it is connected to.
What changes are included in this PR?
SQLGetinfoto return driver and data source informationget_info_cache.ccAre these changes tested?
Will be tested in CI when PR is ready for review
Are there any user-facing changes?
No