Skip to content

GH-47846: [Format] clarify the encoding of the fp16 substrait literal #47847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-47846: [Format] clarify the encoding of the fp16 substrait literal #47847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions format/substrait/extension_types.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,11 @@ types:
- name: u64
structure: {}
# fp16 literals are encoded as user defined literals with
# a google.protobuf.UInt32Value message where the lower 16 bits are
# the fp16 value.
# a google.protobuf.UInt32Value message where the least significant
# 16 bits are the fp16 value encoded with little-endian encoding.
#
# In other words, the least significant 8 bits of the u32 will contain
# the most significant 8 bits of the fp16 value.
- name: fp16
structure: {}
# 64-bit integers are big. Even though date64 stores ms and not days it
Expand Down
Loading