GH-47887: [C++][Integration] Enable extension types with C Data Interface tests #47888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
pitrou
commented
Oct 21, 2025
Member
Author
|
cc @Alex-PLACET |
github-actions
bot
added
awaiting committer review
pitrou
force-pushed
the
gh47887-integration-extension-types
branch
from
fd2063a to
a8ed658
Compare
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 25b351f. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced Oct 23, 2025
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Nov 5, 2025
… Interface tests (apache#47888) ### Rationale for this change Extension type tests were skipped in the C Data Interface tests. ### What changes are included in this PR? * Move C Data Integration testing entrypoints into a dedicated DLL, and make them link to the `arrow_testing` library * Register the required extension types in those entrypoints * Remove the associated skip in the Archery integration testing harness ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#47887 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Extension type tests were skipped in the C Data Interface tests.
What changes are included in this PR?
arrow_testinglibraryAre these changes tested?
Yes.
Are there any user-facing changes?
No.