Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Oct 23, 2025

Rationale for this change

We need to use orc_SOURCE not ORC_SOURCE for Apache ORC and glog_SOURCE not GLOG_SOURCE for Google logging.

What changes are included in this PR?

Fix referred variable names.

Are these changes tested?

Yes in apache/arrow-java#865 .

Are there any user-facing changes?

Yes.

We need to use `orc_SOURCE` not `ORC_SOURCE`.
@github-actions
Copy link

⚠️ GitHub issue #47914 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Oct 23, 2025
@kou kou changed the title GH-47914: [C++] Fix system Apache ORC used detection GH-47914: [C++] Fix system Apache ORC/Google logging used detection Oct 23, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 23, 2025
@raulcd
Copy link
Member

raulcd commented Oct 23, 2025

@github-actions crossbow submit -g cpp

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, will merge once CI finishes if successful

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 23, 2025
@github-actions
Copy link

Revision: 1cef7e1

Submitted crossbow builds: ursacomputing/crossbow @ actions-11243595d4

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@raulcd raulcd merged commit 603901a into apache:main Oct 23, 2025
44 of 47 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 23, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 603901a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants