-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47914: [C++] Fix system Apache ORC/Google logging used detection #47915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need to use `orc_SOURCE` not `ORC_SOURCE`.
|
|
|
@github-actions crossbow submit -g cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM, will merge once CI finishes if successful
|
Revision: 1cef7e1 Submitted crossbow builds: ursacomputing/crossbow @ actions-11243595d4 |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 603901a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We need to use
orc_SOURCEnotORC_SOURCEfor Apache ORC andglog_SOURCEnotGLOG_SOURCEfor Google logging.What changes are included in this PR?
Fix referred variable names.
Are these changes tested?
Yes in apache/arrow-java#865 .
Are there any user-facing changes?
Yes.