GH-47924: [C++] Fix issues in CSV reader with invalid inputs #47925
+140
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
force-pushed
the
gh47924-csv-fuzz
branch
3 times, most recently
from
b35dc77 to
1e77d0e
Compare
|
Ouch, trying to do safe arithmetics in I've opened #47926 so that we can hopefully find another approach. |
These issues were all found by OSS-Fuzz: * https://issues.oss-fuzz.com/issues/452079535 * https://issues.oss-fuzz.com/issues/452079536 * https://issues.oss-fuzz.com/issues/452118314 * https://issues.oss-fuzz.com/issues/452701622 * https://issues.oss-fuzz.com/issues/452912678
pitrou
force-pushed
the
gh47924-csv-fuzz
branch
from
1e77d0e to
23582e7
Compare
|
Ouch, I hoped #47950 had fixed our problem with Windows macros but evidently it hasn't :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
These issues were all found by OSS-Fuzz:
Are these changes tested?
Yes, by additional fuzz regression files.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)