Skip to content

GH-47945: [C++] Add support for Boost 1.89.0 and require Boost 1.69 or later #47947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

GH-47945: [C++] Add support for Boost 1.89.0 and require Boost 1.69 or later #47947

merged 2 commits into from
Oct 30, 2025
+13 −11

Conversation

@kou
Copy link
Member

@kou kou commented Oct 27, 2025 •
edited by github-actions bot
Loading

Rationale for this change

Boost 1.89.0 removed backward compatibility CMake package for Boost.System. Boost.System is header-only since Boost 1.69. So CMake package for Boost.System isn't needed but it's provided for backward compatibility.

CentOS 7 uses Boost 1.69. So we can drop support for Boost 1.68 or older.

What changes are included in this PR?

  • Require Boost 1.69 or later.
  • Remove system from COMPONENTS because Boost.System is header-only.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions
Copy link

⚠️ GitHub issue #47945 has been automatically assigned in GitHub to PR creator.

@kou kou added the CI: Extra Run extra CI label Oct 27, 2025
@kou kou force-pushed the cpp-boost-system branch from 5deedbf to ed1a930 Compare October 27, 2025 01:23
@kou
Copy link
Member Author

kou commented Oct 27, 2025

@lahwaacz Could you try this?

@lahwaacz
Copy link

@kou This seems to work, thanks!

@kou kou force-pushed the cpp-boost-system branch from ed1a930 to 5be3e60 Compare October 27, 2025 23:27
@kou
Copy link
Member Author

kou commented Oct 28, 2025

Thanks. I'll merge this in a few days if nobody objects this.

raulcd
raulcd reviewed Oct 28, 2025
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou this looks good to me, I just have a question of something I don't understand.

ci/conda_env_cpp.txt
gmock>=1.10.0
google-cloud-cpp>=1.34.0
gtest>=1.10.0
libboost-devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Oct 28, 2025
raulcd
raulcd reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to run cpp jobs and approve to merge once CI finished but unfortunately there's is a conflict with main that has to be resolved :(

@kou kou force-pushed the cpp-boost-system branch from 60dacf6 to f00d472 Compare October 29, 2025 21:48
@kou
Copy link
Member Author

kou commented Oct 29, 2025

Oh, sorry. I missed it. I've rebased.

kou added 2 commits October 30, 2025 10:21
@kou
apacheGH-47945: [C++] Require Boost 1.69 or later
1653cc3 
Boost.System is header-only since Boost 1.69.

CentOS 7 uses Boost 1.69. So we can drop support for Boost 1.68 or
older.
@kou
Add 1.89.0 to additional versions
09520e2
@kou kou force-pushed the cpp-boost-system branch from f00d472 to 09520e2 Compare October 30, 2025 01:21
@raulcd
Copy link
Member

raulcd commented Oct 30, 2025

@github-actions crossbow submit -g cpp

raulcd
raulcd approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge once the extra CI jobs are finished. Assuming they don't raise any related issue.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 30, 2025
@github-actions
Copy link

Revision: 09520e2

Submitted crossbow builds: ursacomputing/crossbow @ actions-a680515113

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@raulcd raulcd merged commit 2e46c05 into apache:main Oct 30, 2025
72 of 77 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Oct 30, 2025
@raulcd raulcd mentioned this pull request Oct 30, 2025
Closed
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 2e46c05.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@kou kou deleted the cpp-boost-system branch October 31, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulcd raulcd raulcd approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@jonkeane jonkeane Awaiting requested review from jonkeane jonkeane is a code owner

Assignees

No one assigned

Labels

CI: Extra Run extra CI Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kou @lahwaacz @raulcd