-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47806: [CI] Rename deprecated docker-compose.yml to preferred compose.yaml file #47954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
|
|
@github-actions crossbow submit -g test |
|
Revision: 5aec0ef Submitted crossbow builds: ursacomputing/crossbow @ actions-4f873c6f3b |
|
@github-actions crossbow submit example-python-minimal-build-* |
|
Revision: 5aec0ef Submitted crossbow builds: ursacomputing/crossbow @ actions-ec397c8e59
|
raulcd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the CI failures are related and I've tested several usages of various of our compose.yaml files on the PR
assignUser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hu, didn't know that :D
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks!
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 719c32e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…d compose.yaml file (apache#47954) ### Rationale for this change Docker Compose recommends `compose.yaml`: https://docs.docker.com/compose/intro/compose-application-model/#the-compose-file > The default path for a Compose file is compose.yaml (preferred) or compose.yml that is placed in the working directory. Compose also supports docker-compose.yaml and docker-compose.yml for backwards compatibility of earlier versions. If both files exist, Compose prefers the canonical compose.yaml. ### What changes are included in this PR? - Update several `docker-compose.yml` file names to `compose.yaml` - Update doc and comment references - Update archery references to the file - Update workflows and CODEOWNERS to take new file into account. ### Are these changes tested? Yes via CI and some archery jobs. ### Are there any user-facing changes? No * GitHub Issue: apache#47806 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Docker Compose recommends
compose.yaml:https://docs.docker.com/compose/intro/compose-application-model/#the-compose-file
What changes are included in this PR?
docker-compose.ymlfile names tocompose.yamlAre these changes tested?
Yes via CI and some archery jobs.
Are there any user-facing changes?
No
docker-compose.ymltocompose.yaml#47806