Skip to content

Conversation

@charlespnh
Copy link
Contributor

@charlespnh charlespnh commented Oct 21, 2025

Partially addresses #29650
Implementation follows the exact same as in

class BoundedTrieData(object):
and
* distributed with this work for additional information


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@charlespnh charlespnh changed the title Support BoundedTrie metric for Prism Runner [prism] Support BoundedTrie Metrics Oct 22, 2025
@charlespnh charlespnh force-pushed the lineage-bounded-trie-prism branch from ac8d457 to 1c58afb Compare October 30, 2025 05:41
@charlespnh charlespnh marked this pull request as ready for review November 3, 2025 02:43
@charlespnh
Copy link
Contributor Author

R: @Abacn @shunping @lostluck

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@charlespnh
Copy link
Contributor Author

I don't think the current tests failing are related, though might need to rerun to be certain...

@shunping
Copy link
Collaborator

shunping commented Nov 6, 2025

Thanks! LGTM on the PR.

Re-running the failed tests now.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the complexity of the implementation, a few more unit tests to ensure coverage would be appreciated to ensure correctness.

The Python implementation has a robust set to crib from:

https://github.com/apache/beam/blob/master/sdks/python/apache_beam/metrics/cells_test.py#L217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants