Skip to content

CASSANDRA-20147: Semaphore permit overflow in batch commit mode #4437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+3 −0
Open

CASSANDRA-20147: Semaphore permit overflow in batch commit mode #4437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/java/org/apache/cassandra/db/commitlog/AbstractCommitLogService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ public void run(Interruptible.State state) throws InterruptedException
if (markerIntervalNanos <= 0)
{
haveWork.acquire(1);
haveWork.drain();
}
else
{
Expand All @@ -213,6 +214,7 @@ public void run(Interruptible.State state) throws InterruptedException
long wakeUpAt = pollStarted + markerIntervalNanos;
if (wakeUpAt > now)
haveWork.tryAcquireUntil(1, wakeUpAt);
haveWork.drain();
}
}
catch (Throwable t)
Expand All @@ -221,6 +223,7 @@ public void run(Interruptible.State state) throws InterruptedException
throw new TerminateException();
else // sleep for full poll-interval after an error, so we don't spam the log file
haveWork.tryAcquire(1, markerIntervalNanos, NANOSECONDS);
haveWork.drain();
}
}

Expand Down