CASSANDRA-20984: Fix java.lang.ClassCastException: Issues while joining #4438
+242
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekkoya
changed the title
smiklosovic
reviewed
Oct 27, 2025
| public void testCompatibleVersion() throws InterruptedException, ExecutionException | ||
| { | ||
| Future<Result<Result.StreamingSuccess>> result = streamingConnect(new AcceptVersions(MessagingService.minimum_version, current_version + 1), new AcceptVersions(minimum_version + 2, current_version + 3)); | ||
| if (result.isSuccess()) { |
There was a problem hiding this comment.
I think it would be better if you did Assert.assertTrue(result.isSuccess()) so we can get rid of this if / else logic in each test method.
smiklosovic
reviewed
Oct 27, 2025
| SslFallbackConnectionType.SERVER_CONFIG | ||
| ); | ||
| result.awaitUninterruptibly(); | ||
| return result; |
There was a problem hiding this comment.
can't we Assert.assertTrue(result.isSuccess()); return result.getNow() here? So you would just return Result from this method. It would be easier to work with later on.
There was a problem hiding this comment.
Yes, it reduces duplicate code.
Signed-off-by: vivekkoya <[email protected]>
|
Incorporated changes here: vivekkoya@4e493dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see: https://issues.apache.org/jira/browse/CASSANDRA-20984
Commit messages should follow the following format:
The Cassandra Jira