[CELEBORN-2251] Introducing a shim layer and a common-tiered submodule for Flink clients #3589
+3,344
−19,368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
reviewed
Jan 21, 2026
Member
There was a problem hiding this comment.
@pltbkd, thanks for contribution. Could you update CelebornBuild for new module to build flink celeborn client jar?
SteNicholas
reviewed
Jan 21, 2026
client-flink/common/src/test/java/org/apache/celeborn/plugin/flink/TestUtils.java
Show resolved
Hide resolved
SteNicholas
reviewed
Jan 21, 2026
…e for Flink clients
SteNicholas
changed the title
pltbkd
force-pushed
the
flink-shim-0.7
branch
from
0552da0 to
b3d29d2
Compare
SteNicholas
force-pushed
the
flink-shim-0.7
branch
3 times, most recently
from
e677771 to
6c1a0c7
Compare
…e for Flink clients
SteNicholas
force-pushed
the
flink-shim-0.7
branch
from
6c1a0c7 to
ddc8695
Compare
SteNicholas
approved these changes
Jan 21, 2026
RexXiong
approved these changes
Jan 21, 2026
Contributor
RexXiong
left a comment
RexXiong
left a comment
There was a problem hiding this comment.
LGTM, Great refactoring work for Flink integration! Thanks!
Member
|
Thanks for great refactoring. Merged to main(v0.7.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Though Celeborn now has a client-flink-common submodule, clients still have to copy a lot of code from version to version, with small but necessary changes buried in the duplicates. The tests don’t share a common implementation either. Even worse, with Flink introducing tiered shuffle from 1.20 onward, all tiered shuffle implementations must be placed inside the versioned clients to ensure that client-flink-common can be compiled against all Flink versions. This makes it much harder to evolve the tiered shuffle implementations.
For the maintenance of Flink clients in the future, we need better organization of the submodules, consolidating the implementations and tests.
Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The patch consolidates all current Flink client tests, and can be tested with them.