-
Notifications
You must be signed in to change notification settings - Fork 188
orca: implement intra-segment parallel table scan support #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yjhjstz
wants to merge
5
commits into
apache:main
Choose a base branch
from
yjhjstz:yjhjstz/orca_parallel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cde0dec to
05d9edf
Compare
Contributor
|
Please add more test cases |
my-ship-it
reviewed
Oct 21, 2025
my-ship-it
reviewed
Oct 21, 2025
my-ship-it
reviewed
Oct 21, 2025
my-ship-it
reviewed
Oct 21, 2025
my-ship-it
reviewed
Oct 21, 2025
my-ship-it
reviewed
Oct 21, 2025
my-ship-it
reviewed
Oct 21, 2025
src/backend/gporca/libgpopt/include/gpopt/base/CRewindabilitySpec.h
Outdated
Show resolved
Hide resolved
src/backend/gporca/libgpopt/src/operators/CPhysicalParallelTableScan.cpp
Show resolved
Hide resolved
src/backend/gporca/libgpopt/src/operators/CPhysicalParallelTableScan.cpp
Show resolved
Hide resolved
Member
Author
see src/test/regress:installcheck-orca-parallel |
Add comprehensive parallel table scan capability to GPORCA optimizer, enabling worker-level parallelism within segments for improved query performance on large table scans. Key components: - New CPhysicalParallelTableScan operator and CDistributionSpecWorkerRandom distribution specification for worker-level data distribution - CXformGet2ParallelTableScan transformation with parallel safety checks (excludes CTEs, dynamic scans, foreign tables, replicated tables, etc.) - Cost model integration with parallel_setup_cost and efficiency degradation scaling (logarithmic based on worker count) - DXL serialization/deserialization for CDXLPhysicalParallelTableScan - Plan translation to PostgreSQL SeqScan nodes with parallel_aware=true - Rewindability constraints (parallel scans are non-rewindable) - GUC integration: max_parallel_workers_per_gather controls worker count
revert CDistributionSpecRandom.cpp
05d9edf to
8a5bc1e
Compare
my-ship-it
reviewed
Oct 22, 2025
my-ship-it
reviewed
Oct 22, 2025
my-ship-it
reviewed
Oct 22, 2025
my-ship-it
approved these changes
Oct 23, 2025
Contributor
my-ship-it
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
Add some cases to test the plan? |
Member
Author
maybe after impl parallel hash join . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive parallel table scan capability to GPORCA optimizer, enabling worker-level parallelism within segments for improved query performance on large table scans.
Key components:
Impl #1316
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions