Fix pg_upgrade and pg_dump #1439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lss602726449
force-pushed
the
fix_pgupgrade
branch
from
6519300 to
4283b38
Compare
This commit drops the GPDB specific TypeStorageOptions struct and supporting code in favor of adding pg_type_encoding.typoptions to the getTypes query. The usage of CatalogId as the hash index caused collisions with the TypeInfo indexes when TypeStorageOptions was a unique dumpable object, since the only unique aspect was the typstorage field. Now, when dumpType is called, we check the typstorage field and dump the ALTER TABLE...SET DEFAULT ENCODING TOC entry if needed. Authored-by: Brent Doil <[email protected]>
Reviewed-by: Gang Xiong <[email protected]>
lss602726449
force-pushed
the
fix_pgupgrade
branch
from
4283b38 to
940b289
Compare
my-ship-it
changed the title
1. Add database type and version to pg_upgrade and pg_dump to distinguish different catalogs. 2. Fixed serveral issues encountered when using pg_dump and pg_upgrade.
lss602726449
force-pushed
the
fix_pgupgrade
branch
from
940b289 to
4d9e6cd
Compare
lss602726449
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions