api/test: fix storage pool update with only id #11897

weizhouapache · 2025-10-23T07:06:53Z

Description

This PR fixes the issue below

(localcloud) 🐱 > update storagepool id=92a06402-16ab-35e8-950e-d84499c5e942 
🙈 Error: (HTTP 530, error code 9999) Failed to update storage pool
(localcloud) 🐱 >

This PR also fixes the issue during smoke tests that the tags are not remove in test_direct_download.py

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2025-10-23T07:07:05Z

@blueorangutan package

blueorangutan · 2025-10-23T07:08:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-10-23T07:14:25Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.18%. Comparing base (e333ce9) to head (94f2ea8).
⚠️ Report is 3 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...pi/command/admin/storage/UpdateStoragePoolCmd.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11897   +/-   ##
=========================================
  Coverage     16.18%   16.18%           
- Complexity    13302    13304    +2     
=========================================
  Files          5657     5657           
  Lines        498464   498465    +1     
  Branches      60491    60491           
=========================================
+ Hits          80674    80689   +15     
+ Misses       408810   408794   -16     
- Partials       8980     8982    +2

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.04% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-10-23T08:07:15Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15531

weizhouapache · 2025-10-23T08:28:14Z

@blueorangutan test

blueorangutan · 2025-10-23T08:30:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland

clgtm

blueorangutan · 2025-10-24T05:22:11Z

[SF] Trillian test result (tid-14712)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 70991 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14712-kvm-ol8.zip
Smoke tests completed. 139 look OK, 1 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	`Failure`	547.99	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	371.24	test_vpc_vpn.py
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py

DaanHoogland · 2025-10-24T10:00:22Z

no related error here

[SF] Trillian test result (tid-14712) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 70991 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14712-kvm-ol8.zip Smoke tests completed. 139 look OK, 1 have errors, 1 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Failure 547.99 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 371.24 test_vpc_vpn.py
all_test_human_readable_logs Skipped --- test_human_readable_logs.py

I suggest doing the ful test matrix. not sure if manual testing makes sense on top of that, @weizhouapache ?

weizhouapache · 2025-10-24T10:03:06Z

@blueorangutan package

blueorangutan · 2025-10-24T10:04:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache · 2025-10-24T10:04:08Z

no related error here

[SF] Trillian test result (tid-14712) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 70991 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14712-kvm-ol8.zip Smoke tests completed. 139 look OK, 1 have errors, 1 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Failure 547.99 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 371.24 test_vpc_vpn.py
all_test_human_readable_logs Skipped --- test_human_readable_logs.py

I suggest doing the ful test matrix. not sure if manual testing makes sense on top of that, @weizhouapache ?

ok.
I just updated 4.20 branch to 4.20.3.0-SNAPSHOT, let's re-package and run test matrix to test both changes

weizhouapache · 2025-10-24T10:05:34Z

not sure if manual testing makes sense on top of that, @weizhouapache ?

manual testing is quite simple, easy to reproduce and easy to verify. see the description

blueorangutan · 2025-10-24T12:17:47Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15548

weizhouapache · 2025-10-24T12:21:53Z

@blueorangutan test matrix

blueorangutan · 2025-10-24T12:24:04Z

@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-10-25T09:07:36Z

[SF] Trillian test result (tid-14719)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 70115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14719-kvm-ol8.zip
Smoke tests completed. 138 look OK, 2 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_primary_storage_nfs	`Error`	0.35	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.61	test_primary_storage.py
test_01_primary_storage_scope_change	`Error`	0.19	test_primary_storage_scope.py
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py

blueorangutan · 2025-10-25T11:39:26Z

[SF] Trillian test result (tid-14720)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 79705 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14720-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 0 have errors, 2 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py
all_test_image_store_object_migration	`Skipped`	---	test_image_store_object_migration.py

blueorangutan · 2025-10-25T13:03:18Z

[SF] Trillian test result (tid-14721)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 84557 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14721-vmware-70u3.zip
Smoke tests completed. 139 look OK, 0 have errors, 2 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py
all_test_image_store_object_migration	`Skipped`	---	test_image_store_object_migration.py

weizhouapache · 2025-10-25T22:06:17Z

@blueorangutan test matrix

blueorangutan · 2025-10-25T22:08:03Z

@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-10-25T23:03:05Z

[SF] Trillian Build Failed (tid-14727)

blueorangutan · 2025-10-26T00:55:03Z

[SF] Trillian test result (tid-14722)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 127802 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14722-xcpng82.zip
Smoke tests completed. 133 look OK, 4 have errors, 4 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_arping_in_ssvm	`Failure`	6.58	test_diagnostics.py
test_01_deployVMInSharedNetwork	`Error`	686.63	test_network.py
test_01_volume_usage	`Failure`	603.76	test_usage.py
test_01_scale_up_verify	`Failure`	577.61	test_vm_autoscaling.py
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py
all_test_image_store_object_migration	`Skipped`	---	test_image_store_object_migration.py
all_test_import_unmanage_volumes	`Skipped`	---	test_import_unmanage_volumes.py
all_test_internal_lb	`Skipped`	---	test_internal_lb.py

blueorangutan · 2025-10-26T17:12:07Z

[SF] Trillian test result (tid-14725)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 64266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14725-kvm-ol8.zip
Smoke tests completed. 136 look OK, 2 have errors, 3 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	`Error`	0.00	test_cluster_drs.py
test_list_system_vms_metrics_history	`Failure`	0.46	test_metrics_api.py
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py
all_test_image_store_object_migration	`Skipped`	---	test_image_store_object_migration.py
all_test_import_unmanage_volumes	`Skipped`	---	test_import_unmanage_volumes.py

blueorangutan · 2025-10-26T21:28:41Z

[SF] Trillian test result (tid-14726)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 80381 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14726-kvm-ubuntu22.zip
Smoke tests completed. 138 look OK, 2 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_enableHumanReadableLogs	`Error`	0.21	test_human_readable_logs.py
test_01_redundant_vpc_site2site_vpn	`Failure`	708.25	test_vpc_vpn.py
all_test_image_store_object_migration	`Skipped`	---	test_image_store_object_migration.py

blueorangutan · 2025-10-27T10:44:42Z

[SF] Trillian test result (tid-14728)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 128142 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11897-t14728-xcpng82.zip
Smoke tests completed. 132 look OK, 6 have errors, 3 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deployVMInSharedNetwork	`Error`	601.23	test_network.py
test_02_restore_vm_with_disk_offering	`Error`	667.65	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	`Error`	668.72	test_restore_vm.py
test_01_volume_usage	`Failure`	676.64	test_usage.py
test_01_scale_up_verify	`Failure`	577.83	test_vm_autoscaling.py
test_02_update_vmprofile_and_vmgroup	`Failure`	269.71	test_vm_autoscaling.py
test_01_restore_vm_strict_tags_success	`Error`	732.84	test_vm_strict_host_tags.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	1524.24	test_host_maintenance.py
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py
all_test_image_store_object_migration	`Skipped`	---	test_image_store_object_migration.py
all_test_import_unmanage_volumes	`Skipped`	---	test_import_unmanage_volumes.py

DaanHoogland · 2025-10-27T13:38:00Z

@blueorangutan package

blueorangutan · 2025-10-27T13:40:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-27T14:49:01Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15572

DaanHoogland

tested in a lab env, functionally good 👍

harikrishna-patnala

code LGTM

shwstppr

code lgtm

boring-cyborg bot added component:api component:integration-test Python Warning... Python code Ahead! labels Oct 23, 2025

weizhouapache marked this pull request as ready for review October 23, 2025 07:06

weizhouapache added this to the 4.20.2 milestone Oct 23, 2025

DaanHoogland approved these changes Oct 23, 2025

View reviewed changes

weizhouapache modified the milestones: 4.20.2, 4.20.3 Oct 23, 2025

weizhouapache added 2 commits October 24, 2025 12:44

api: cannot update storage pool with empty parameters

e7105ae

test: fix storage pool tags is not updated when test is done

94f2ea8

DaanHoogland force-pushed the 4.20-fix-update-storagepool branch from 45ec6df to 94f2ea8 Compare October 24, 2025 10:44

DaanHoogland approved these changes Oct 28, 2025

View reviewed changes

DaanHoogland added the status:needs-review label Oct 30, 2025

harikrishna-patnala approved these changes Oct 30, 2025

View reviewed changes

DaanHoogland added status:ready-for-merge and removed status:needs-review labels Oct 30, 2025

shwstppr approved these changes Nov 3, 2025

View reviewed changes

DaanHoogland merged commit d53b6db into apache:4.20 Nov 3, 2025
41 of 43 checks passed

api/test: fix storage pool update with only id #11897

api/test: fix storage pool update with only id #11897

Conversation

weizhouapache commented Oct 23, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Oct 23, 2025

Uh oh!

blueorangutan commented Oct 23, 2025

Uh oh!

codecov bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 23, 2025

Uh oh!

weizhouapache commented Oct 23, 2025

Uh oh!

blueorangutan commented Oct 23, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

DaanHoogland commented Oct 24, 2025

Uh oh!

weizhouapache commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

weizhouapache commented Oct 24, 2025

Uh oh!

weizhouapache commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

weizhouapache commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 25, 2025

Uh oh!

blueorangutan commented Oct 25, 2025

Uh oh!

blueorangutan commented Oct 25, 2025

Uh oh!

weizhouapache commented Oct 25, 2025

Uh oh!

blueorangutan commented Oct 25, 2025

Uh oh!

blueorangutan commented Oct 25, 2025

Uh oh!

blueorangutan commented Oct 26, 2025

Uh oh!

blueorangutan commented Oct 26, 2025

Uh oh!

blueorangutan commented Oct 26, 2025

Uh oh!

blueorangutan commented Oct 27, 2025

Uh oh!

DaanHoogland commented Oct 27, 2025

Uh oh!

blueorangutan commented Oct 27, 2025

Uh oh!

blueorangutan commented Oct 27, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 23, 2025 •

edited

Loading