server: skip setting vm password when restored from backup

[shwstppr]

Description

Fixes #11941

User can use the same password as the original VM at the time of backup. Or else the reset password option can be used. Behaviour can be documented.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (bfc4f60) to head (5129b00).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11948   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15540    15544    +4     
=========================================
  Files          5909     5909           
  Lines        529045   529061   +16     
  Branches      64615    64618    +3     
=========================================
+ Hits          92933    92943   +10     
- Misses       425657   425664    +7     
+ Partials      10455    10454    -1     

Flag	Coverage Δ
uitests	3.58% <ø> (ø)
unittests	18.63% <80.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[abh1sar]

@shwstppr Does it show the password on vm creation from backup like it does for normal vm creation?

[shwstppr]

@abh1sar no. I don't think that will be possible. We don't store the password with the backup (even with VM entry in the DB).
Also, depending on when backup is taken, password can be different.
I think it would be better to document or somehow try to show a dialog after deployment that the password should be reset.