Skip to content

Update TiffImageMetadata.java #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clagenna wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update TiffImageMetadata.java #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,15 @@ public GpsInfo(final String latitudeRef, final String longitudeRef, final Ration

public double getLatitudeAsDegreesNorth() throws ImagingException {
final double result = latitudeDegrees.doubleValue() + latitudeMinutes.doubleValue() / 60.0 + latitudeSeconds.doubleValue() / 3600.0;

if (latitudeRef.trim().equalsIgnoreCase("n")) {
/* Due to some HEIC file converters to JPG longitude and latitude strings gets converted from UNICODE
* with wrong UTF-8 coding. e.g. North "N" have hex bytes hex:4e ef bf bd<br/>
* For that reason latitudeRef.trim().equalsIgnoreCase("n") fails. My suggestion
* is to use substring(0, 1) instead of trim()
*/
if (latitudeRef.substring(0, 1).equalsIgnoreCase("n")) {
return result;
}
if (latitudeRef.trim().equalsIgnoreCase("s")) {
if (latitudeRef.substring(0, 1).equalsIgnoreCase("s")) {
return -result;
}
throw new ImagingException("Unknown latitude ref: \"" + latitudeRef + "\"");
Expand All @@ -186,10 +190,10 @@ public double getLatitudeAsDegreesNorth() throws ImagingException {
public double getLongitudeAsDegreesEast() throws ImagingException {
final double result = longitudeDegrees.doubleValue() + longitudeMinutes.doubleValue() / 60.0 + longitudeSeconds.doubleValue() / 3600.0;

if (longitudeRef.trim().equalsIgnoreCase("e")) {
if (longitudeRef.substring(0, 1).equalsIgnoreCase("e")) {
return result;
}
if (longitudeRef.trim().equalsIgnoreCase("w")) {
if (longitudeRef.substring(0, 1).equalsIgnoreCase("w")) {
return -result;
}
throw new ImagingException("Unknown longitude ref: \"" + longitudeRef + "\"");
Expand Down