Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Add new metric (histogram) to track number of reads using _bulk_get #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new metric (histogram) to track number of reads using _bulk_get #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/chttpd_db.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ db_req(#httpd{method='POST', path_parts=[_, <<"_bulk_get">>]}=Req, Db) ->
undefined ->
throw({bad_request, <<"Missing JSON list of 'docs'.">>});
Docs ->
couch_stats:update_histogram([couchdb, httpd, bulk_reads], length(Docs)),
Copy link
Member

@kxepal kxepal May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name is confusing. If we want to count only "/_bulk_get" requests here, better give such name to the metric instead of generic bulk_reads. Otherwise, if you want to use "bulk_reads", should we count requests with include_docs=true to views and all_docs as bulk reads?

#doc_query_args{
options = Options
} = bulk_get_parse_doc_query(Req),
Expand Down