Extract source comments #2107
Open
Extract source comments #2107
+410
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xitep
force-pushed
the
extract-source-comments
branch
from
f5409bf to
cb94d6a
Compare
xitep
force-pushed
the
extract-source-comments
branch
2 times, most recently
from
029c3d0 to
49fe387
Compare
Since the parser's API is too widely open, users can easily break the binary search provided by `Comments::find`. One possibility could be to expose `Parser::into_comments` sorting the comments first, but have `Parser::parse_sql_with_comments` do wihtout. To be decided later.
xitep
force-pushed
the
extract-source-comments
branch
from
49fe387 to
87c321c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.