Refactor FileSource constructors to take a schema
#18386
+576
−371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these file source implementations cannot operate without schema, they all have
.expect("schema must be set")s that violate using the language to enforce correctness.This is an attempt to rework that by making it so you have to pass in a schema to construct them.
That said there are downsides:
FileScanConfigandFileSourcematch.I feel like there's another twist to this needed... maybe moving the schema out of
FileScanConfig? That's not currently possible, it's used in both places. Maybe having aFileScanand aFileScanConfigand having construction beFileScan::new(FileSource::new(config), config)?