Skip to content

FELIX-6217: Avoid NoSuchElementException in RootCauseCommand #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

FELIX-6217: Avoid NoSuchElementException in RootCauseCommand #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions rootcause/src/main/java/org/apache/felix/rootcause/RootCauseCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package org.apache.felix.rootcause;

import java.util.Optional;
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Reference;
import org.osgi.service.component.runtime.ServiceComponentRuntime;
Expand All @@ -34,13 +35,15 @@ public class RootCauseCommand {

@Reference
ServiceComponentRuntime scr;

public DSComp rootcause(String componentName) {
ComponentDescriptionDTO cdesc = scr.getComponentDescriptionDTOs().stream()
.filter(desc -> desc.name.equals(componentName))
.findFirst().get();
DSComp rootCause = new DSRootCause(scr).getRootCause(cdesc);
new RootCausePrinter().print(rootCause);
return rootCause;
}


public DSComp rootcause(String componentName) {
Optional<DSComp> rootCause = scr.getComponentDescriptionDTOs().stream()
.filter(desc -> desc.name.equals(componentName))
.findFirst()
.map(cdesc -> new DSRootCause(scr).getRootCause(cdesc));

rootCause.ifPresent(rc -> new RootCausePrinter().print(rc));
return rootCause.orElseGet(null);
}
}