[Client] Fix LogFetcher doesn't update bucket metadata when receive NotLeaderOrFollowerException in bucket level #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swuferhong
force-pushed
the
logFetcher-fix
branch
from
9cfd5cc to
49c2255
Compare
…otLeaderOrFollowerException in bucket level
swuferhong
force-pushed
the
logFetcher-fix
branch
from
49c2255 to
1c38a02
Compare
Member
|
Waiting for metadata V2 (partition not found should be embedded in bucket response and not fail the client), and continue to review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1884
Currently,
LogFetcheronly updates metadata inhandleFetchLogExceptionwhen anInvalidMetadataExceptionis received. However, it does not handle bucket-level InvalidMetadataException, such asNotLeaderOrFollowerException, because these error in bucket level were passed in bucket response as error code.Brief change log
Tests
API and Format
Documentation