Skip to content

Conversation

@wuchong
Copy link
Member

@wuchong wuchong commented Nov 2, 2025

Purpose

This fixes the release issues mentioned by JB in the vote thread: https://lists.apache.org/thread/pyccbmxoz9wnf6m3blcrcvj8j9gzyow8

+1 (binding)

NB: the binary distribution should be fixed (see later).

I checked:

  • Source distribution
    -- incubating is in the name/version
    -- signature and checksum are good
    -- DISCLAIMER is there
    -- LICENSE and NOTICE are good (NB: it would be good to mention Maven
    in LICENSE/NOTICE as we bundle mvnw in the source distribution)
    -- No binary file found in the source distribution
    -- ASF header is present in expected files and good (just missing in a
    couple of README.md, but not blocker/required)
  • Binary distribution
    -- incubating is in the name/version
    -- signature and checksum are good
    -- DISCLAIMER is missing in the source distribution
    -- LICENSE is missing in the root directory (for Fluss itself)
    -- LICENSE files in the licenses directory and NOTICE file are good
    -- ASF header is present in configuration file (in the conf folder)

Thanks,
Regards
JB

Linked issue: close #xxx

Brief change log

  • fix the create_binary_release.sh to copy the DISCLAIMER and LICENSE from the project root directory.
  • Add ASF headers to README.md files
  • Add mvnw files entries in LICENSE and NOTICE

Tests

API and Format

Documentation

@jbonofre jbonofre self-requested a review November 2, 2025 17:44
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.

$MVN clean package -Prelease -am -Dgpg.skip -Dcheckstyle.skip=true -DskipTests

cd fluss-dist/target/fluss-${RELEASE_VERSION}-bin
cp ${FLUSS_DIR}/LICENSE ./fluss-${RELEASE_VERSION}/LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the LICENSE from the source distribution right ?

I guess we need a specific one for the binary distribution (as we bundle dependencies).

Maybe we can do another PR specifically for LICENSE and NOTICE in the binary distribution.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this copies LICENSE file from source code to the binary distribution to fix the missing LICENSE in binary distribution. I think the LICENSE file in source distribution is correct, right?

The NOTICE file already exists in binary distribution, this PR just append the NOTICE content in source code into the existing binary NOTICE file.

@wuchong
Copy link
Member Author

wuchong commented Nov 9, 2025

Hi @jbonofre,

I’ve tested the PR locally, and it correctly generates the LICENSE and DISCLAIMER files in the binary distribution.

I’ll go ahead and merge this for now. If anything is missing or needs refinement, I’ll follow up with additional PRs.

image

@wuchong wuchong merged commit d5992aa into apache:main Nov 9, 2025
6 checks passed
@wuchong wuchong deleted the fix-release-issue branch November 9, 2025 15:28
@jbonofre
Copy link
Member

jbonofre commented Nov 9, 2025

Yeah I will create another PR because the LICENSE is correct for source distribution but not binary distribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants