-
Notifications
You must be signed in to change notification settings - Fork 427
[Client] Fix LookupSender doesn't update bucket metadata when receive NotLeaderOrFollowerException in bucket level #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7111edb to
dd427e3
Compare
loserwang1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a comment.
| this.tablePartitions = tablePartitions; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is same as LogFetcher, can we extract this same code in protected class? If some problem occurs, we only need to change once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is same as LogFetcher, can we extract this same code in protected class? If some problem occurs, we only need to change once.
@wuchong will refactor the client metadata code implement, so there is no need to uniform. It's sufficient to have test coverage.
luoyuxia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems "// todo: try to get value when get is re-triable in FLUSS-56857409" can be finished with this pr?
This PR may not be able to fix the issue. Only when the |
Hi, @platinumhamburg. Your PR #1915 has already addressed this issue. Could you please remove this |
dd427e3 to
0cabbba
Compare
… NotLeaderOrFollowerException in bucket level
0cabbba to
329f24f
Compare
I thought about it, and PR #1915 currently does not implement infinite retries nor support delayed backoff retries. In fact, even with limited retries, a single lookup does not guarantee the "deterministic" result expected here, so this TODO item should not be removed in PR #1915. |
loserwang1024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Linked issue: close #1927
This pr is aims to fix
LookupSenderdoesn't update bucket metadata when receive NotLeaderOrFollowerException in bucket levelBrief change log
Tests
API and Format
Documentation