Skip to content

Conversation

@Blazer-007
Copy link
Member

@Blazer-007 Blazer-007 commented Oct 30, 2025

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    GobblinTemporalJobScheduler was created for temporal job launches but most of the code was taken from GobblinHelixJobScheduler which uses HelixJobsMapping to store running jobs, cancelling or deleting them and is used mostly from GobblinCluster not from Gobblin-on-Temporal

GobblinClusterConfigurationKeys.CLEAN_ALL_DIST_JOBS -- "gobblin.cluster.bootup.clean.dist.jobs" default value is false and is not used in Temporal, this is used in GobblinCluster only

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Blazer-007 Blazer-007 changed the title [GOBBLIN-XXX] Remove helix jobs mapping from temporal job scheduler [GOBBLIN-2235] Remove helix jobs mapping from temporal job scheduler Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant