Kafka Connect: Fix recursive schemas and empty structs in schema conversion #14834
+159
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same error can happen with Avro and empty structs, as I found out recently. Would it be better to thrown an error than default to a string? I'm really not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes StackOverflowError when converting Kafka Connect schemas that contain recursive type references (e.g., protobuf's
google.protobuf.Structor self-referencing messages likemessage Node { repeated Node children = 1; }).Additionally, this change handles empty structs (protobuf messages with no fields) by converting them to StringType, since Parquet cannot write empty groups.
Attempts to address #14697