perf: replace isTemporary(property) check with removing all the temporary properties first #5956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
better_recover
branch
2 times, most recently
from
ff5b755 to
2ec0db4
Compare
…rary properties first
vlsi
force-pushed
the
better_recover
branch
2 times, most recently
from
728c0c7 to
3d8f97d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out "merge properties" and "multi properties" are non-trivial.
For instance,
HTTP Request Defaultsmerges ALL the properties, not just http-related.In that regard, it merges
TestElement.nameas well which is unexpected from my point of view.Leaving this PR aside for now, as it looks like it is hard to get right.