Skip to content

MINOR: Fix typos in RPC files #20800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2025
Merged

MINOR: Fix typos in RPC files #20800

merged 2 commits into from
Nov 2, 2025

Conversation

@sjhajharia
Copy link
Collaborator

@sjhajharia sjhajharia commented Oct 31, 2025 •
edited by github-actions bot
Loading

There are some minor typos in our RPC jsons. The PR fixes the same for
consistency.

Reviewers: Andrew Schofield [email protected], Chia-Ping Tsai
[email protected]

@github-actions github-actions bot added triage PRs from the community clients small Small PRs labels Oct 31, 2025
@AndrewJSchofield AndrewJSchofield self-requested a review October 31, 2025 18:05
@AndrewJSchofield AndrewJSchofield added ci-approved and removed triage PRs from the community labels Oct 31, 2025
AndrewJSchofield
AndrewJSchofield approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I noticed "Apacke" the other day too :)

chia7712
chia7712 reviewed Nov 1, 2025
View reviewed changes
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjhajharia thanks for this patch.

could you please add header to https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/message/AlterShareGroupOffsetsResponse.json ?

@sjhajharia
Copy link
Collaborator Author

sjhajharia commented Nov 2, 2025

Thanks for the reviews.
@chia7712 I have added the changes in the mentioned file.
@AndrewJSchofield I agree. The OCD in me saw the file and couldn't hold back :/

@AndrewJSchofield AndrewJSchofield merged commit 806baad into apache:trunk Nov 2, 2025
22 checks passed
@mimaison
Copy link
Member

mimaison commented Nov 3, 2025

Could we configure Apache RAT to check the JSON files? Ideally these should be caught when building the project.

@chia7712
Copy link
Member

chia7712 commented Nov 3, 2025

Could we configure Apache RAT to check the JSON files? Ideally these should be caught when building the project.

I could not find a way to check json header with RAT, but we can address this by implementing a custom gradle task instead. will file a minor patch for it

@mingyen066 mingyen066 mentioned this pull request Nov 4, 2025
Open
eduwercamacaro pushed a commit to littlehorse-enterprises/kafka that referenced this pull request Nov 12, 2025
@sjhajharia @eduwercamacaro
MINOR: Fix typos in RPC files (apache#20800)
75ed7f8 
There are some minor typos in our RPC jsons. The PR fixes the same for
consistency.

Reviewers: Andrew Schofield <[email protected]>, Chia-Ping Tsai
<[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chia7712 chia7712 chia7712 left review comments

@AndrewJSchofield AndrewJSchofield AndrewJSchofield approved these changes

Assignees

No one assigned

Labels

ci-approved clients small Small PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjhajharia @mimaison @chia7712 @AndrewJSchofield