Update README and website files for clarity and accuracy #575
Conversation
|
lgtm @rawkintrevo @andrewmusselman You guys also have a look |
rawkintrevo
left a comment
rawkintrevo
left a comment
There was a problem hiding this comment.
One good catch, one need clarification, one incorrect change.
| <div class="container position-relative mb-auto"> | ||
| <h2 class="mb-4">For Creating Scalable Performant Machine Learning Applications</h2> | ||
| <a class="btn btn-lg btn-light btn-download mb-3" href="https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&filename=mahout/{{ site.mahout-version }}/mahout-qumat-{{ site.mahout-version }}.zip"><i class="fa fa-download"></i> Download Mahout</a> | ||
| <a class="btn btn-lg btn-light btn-download mb-3" href="https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&filename=mahout/{{ site.mahout-version }}/mahout-qumat-{{ site.mahout-version }}.zip"><i class="fa fa-download"></i> Download Mahout Qumat</a> |
There was a problem hiding this comment.
@andrewmusselman is this accurate? does the mirror point to qumat code now?
website/README.md
Outdated
| # 1.Clone the repository | ||
| ```bash | ||
| git clone https://github.com/username/mahout.git | ||
| git clone https://github.com/apache/mahout.git |
There was a problem hiding this comment.
this is incorrect. you should fork the repository then clone your fork
There was a problem hiding this comment.
However, it should probably note above this (now that I'm looking at the entire file I see that it doesn't).
Perhaps a # 0. Fork the repository
There was a problem hiding this comment.
Sure, I got that. I've update with phase 0 and reorganize the doc.
website/README.md
Outdated
| # 1.Clone the repository | ||
| ```bash | ||
| git clone https://github.com/username/mahout.git | ||
| git clone https://github.com/apache/mahout.git |
There was a problem hiding this comment.
However, it should probably note above this (now that I'm looking at the entire file I see that it doesn't).
Perhaps a # 0. Fork the repository
guan404ming
force-pushed
the
fix-qumat-readme
branch
from
16b7955 to
f371826
Compare
|
lgtm |
|
Thanks! |
3 participants
Purpose of PR
Update README and website files
Linked Issues
Add links to related issues.
Changes Made
Important ToDos
Please mark each with an "x"
A GitHub issue exists (if not, please create one) [https://github.com/apache/mahout/issues]
If all of these items are not yet complete, but you still feel it is appropriate to open a PR, please open it as a Draft PR instead.
Once all requirements are met, you can mark it as ready for review.
Breaking Changes
Does this PR introduce a breaking change?
Testing & Verification
Describe how you tested the changes.
Checklist