Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Oct 29, 2025

Purpose of PR

This PR prevents errors that would occur when trying to execute an empty circuit

Linked Issues

Add links to related issues.

Changes Made

  • Bug fix
  • New feature
  • Documentation update

Important ToDos

Please mark each with an "x"

A GitHub issue exists (if not, please create one) [https://github.com/apache/mahout/issues]

  • Title of PR is "Issue #XXXX: Brief Description of Changes" where XXXX is the GitHub issue number.
  • Created unit tests where appropriate
  • Added correct licenses on newly added files
  • Assigned GitHub issue to self
  • Added documentation in ScalaDocs/JavaDocs and to the website
  • Successfully built and ran all unit tests, verified that all tests pass locally

If all of these items are not yet complete, but you still feel it is appropriate to open a PR, please open it as a Draft PR instead.
Once all requirements are met, you can mark it as ready for review.

Breaking Changes

Does this PR introduce a breaking change?

  • Yes
  • No

Testing & Verification

Describe how you tested the changes.

  • Unit tests added
  • Manually tested

Checklist

  • The title follows the format "MAHOUT-XXXX Brief Description"
  • GitHub issue is created
  • Code follows ASF guidelines

Copy link
Contributor

@andrewmusselman andrewmusselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks @guan404ming

@andrewmusselman
Copy link
Contributor

@guan404ming let's fix the failing tests before merging; if this is reliant on something already merged we could possibly go for it

@guan404ming guan404ming merged commit a35d5e2 into apache:main Nov 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants